Skip to content

REST API: Add tests verifying media_details.sizes is an object when empty #13685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robelsust wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

REST API: Add tests verifying media_details.sizes is an object when empty #13685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ee8662
REST API: Add tests verifying media_details.sizes is an object when e…
robelsust Sep 23, 2026
de505dd
Merge branch 'trunk' into fix/65251-rest-media-sizes
robelsust Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions tests/phpunit/tests/rest-api/rest-attachments-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1194,6 +1194,63 @@ public function test_get_item_sizes_with_no_url() {
$this->assertArrayNotHasKey( 'source_url', $data['media_details']['sizes']['rest-api-test'] );
}

/**
* @ticket 65251
*/
public function test_get_item_sizes_empty_sizes_is_object() {
$attachment_id = self::factory()->attachment->create_object(
self::$test_file,
0,
array(
'post_mime_type' => 'image/jpeg',
'post_excerpt' => 'A sample caption',
),
self::$test_file
);

wp_update_attachment_metadata(
$attachment_id,
array(
'width' => 50,
'height' => 50,
'file' => 'canola.jpg',
'sizes' => array(),
'image_meta' => array(),
)
);

$request = new WP_REST_Request( 'GET', '/wp/v2/media/' . $attachment_id );
$response = rest_get_server()->dispatch( $request );
$data = $response->get_data();

$this->assertInstanceOf( 'stdClass', $data['media_details']['sizes'], 'Sizes should be an empty object (stdClass) when empty.' );
$this->assertSame( '{}', wp_json_encode( $data['media_details']['sizes'] ), 'Sizes must JSON-encode as an empty object.' );
}

/**
* @ticket 65251
*/
public function test_get_item_empty_media_details_is_object() {
$attachment_id = self::factory()->attachment->create_object(
self::$test_file,
0,
array(
'post_mime_type' => 'image/jpeg',
'post_excerpt' => 'A sample caption',
),
self::$test_file
);

delete_post_meta( $attachment_id, '_wp_attachment_metadata' );

$request = new WP_REST_Request( 'GET', '/wp/v2/media/' . $attachment_id );
$response = rest_get_server()->dispatch( $request );
$data = $response->get_data();

$this->assertInstanceOf( 'stdClass', $data['media_details'], 'media_details should be an empty object (stdClass) when metadata is missing.' );
$this->assertSame( '{}', wp_json_encode( $data['media_details'] ), 'media_details must JSON-encode as an empty object.' );
}

public function test_get_item_private_post_not_authenticated() {
wp_set_current_user( 0 );
$draft_post = self::factory()->post->create( array( 'post_status' => 'draft' ) );
Expand Down
Loading