Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…mpty. See #65251.
robelsust
force-pushed
the
fix/65251-rest-media-sizes
branch
from
September 23, 2026 15:16
9e982c4 to
6ee8662
Compare
huzaifaalmesbah
approved these changes
Oct 21, 2026
huzaifaalmesbah
left a comment
huzaifaalmesbah
left a comment
Member
There was a problem hiding this comment.
Thanks for working on this, @robelsust! I really appreciate you locking in both empty object paths in prepare_item_for_response(), neither had a direct test before. Looks good to me.
AI Review: Opus 5.5
Author
|
@github-actions refresh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests verifying that
media_details.sizes(andmedia_detailsitself) returns an empty object{}when sizes or metadata are empty, ensuring consistency with the JSON schema typeobject.Trac ticket: https://core.trac.wordpress.org/ticket/65251