Conversation
d33bs
approved these changes
May 7, 2025
added 4 commits
May 7, 2025 10:44
1. adding more type hints 2. increasing documentation
MattsonCam
force-pushed
the
fix_column_reference
branch
from
84c6f7f to
b4491c5
Compare
d33bs
approved these changes
May 7, 2025
Member
d33bs
left a comment
d33bs
left a comment
There was a problem hiding this comment.
With a move to PDV you may want to consider tagging the previous commits with the related git tag for the version reference at some point. This won't impact things moving forward but could help reduce confusion in the future.
according to pr comments
Member
Author
|
Thanks for the suggestions @d33bs, merging now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug by using correct columns to check if values are the same between corresponding group columns, and also incremented the version patch.