fix label image dimension mis match#12
Open
MikeLippincott wants to merge 3 commits intoWayScience:mainfrom
Open
fix label image dimension mis match#12MikeLippincott wants to merge 3 commits intoWayScience:mainfrom
MikeLippincott wants to merge 3 commits intoWayScience:mainfrom
Conversation
d33bs
reviewed
Jan 25, 2025
Member
d33bs
left a comment
There was a problem hiding this comment.
Nice catch and fix! Leaving some comments here as I noticed this PR come up and had some thoughts. This might be a bit too preemptive and if so, apologies.
- It looked like we might need a
pre-commit runperformed on this to help fix the newline issue (not absolutely certain). - Consider adding a test for this somehow to help make sure the new capability is validated. It could be possible to use the existing generate script under
tests/data/...as an example of how to generate data for this. The variable undertests/utils.pycan be used to add the test case to many of the existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed a bug referenced in issue #11. I added a check of array dimensions prior to concatenating labels with raw images
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.