Merged
Conversation
added 3 commits
January 23, 2026 14:26
to prevent sampling more samples than available
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Pull request overview
Adds a workflow to compute UMAP embeddings from sampled JUMP single-cell data and generate labeled UMAP visualizations (treatment type, anomaly score, control type).
Changes:
- Pin
umap-learnin the conda environment for compatibility with the repo’s scikit-learn version. - Add a notebook + nbconverted Python script to sample per-plate single cells and compute 2D UMAP coordinates.
- Add an nbconverted R script to render and save UMAP figures colored by multiple metadata fields.
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
environment.yml |
Pins umap-learn to a specific version to support the new UMAP computation workflow. |
3.analyze_data/visualize_umaps/nbconverted/compute_plate_umaps.py |
Implements plate sampling + UMAP computation and writes a parquet used for plotting. |
3.analyze_data/visualize_umaps/compute_plate_umaps.ipynb |
Notebook version of the UMAP sampling/computation workflow. |
3.analyze_data/visualize_umaps/nbconverted/visualize_plate_umaps.r |
Generates and saves UMAP plots labeled by treatment type, anomaly score, and control type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3.analyze_data/visualize_umaps/nbconverted/visualize_plate_umaps.r
Outdated
Show resolved
Hide resolved
3.analyze_data/visualize_umaps/nbconverted/compute_plate_umaps.py
Outdated
Show resolved
Hide resolved
3.analyze_data/visualize_umaps/nbconverted/compute_plate_umaps.py
Outdated
Show resolved
Hide resolved
3.analyze_data/visualize_umaps/nbconverted/compute_plate_umaps.py
Outdated
Show resolved
Hide resolved
d33bs
approved these changes
Jan 26, 2026
3.analyze_data/visualize_umaps/nbconverted/compute_plate_umaps.py
Outdated
Show resolved
Hide resolved
|
@MattsonCam I've opened a new pull request, #61, to work on those changes. Once the pull request is ready, I'll request review from you. |
Member
Author
|
Thanks @d33bs, merging now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computed UMAP from sampled JUMP data and visualized UMAPs labeled by different categories.