Skip to content

test: summary concurrency test waits for the expected overlap #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rejojer merged 1 commit into from
Oct 1, 2026
Merged

test: summary concurrency test waits for the expected overlap #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3271,11 +3271,17 @@ def roots():
"structure": roots(), "page_texts": list(pages)})
in_flight = {"expand": 0, "summary": 0}
peak = {"expand": 0, "summary": 0}
want = {}

async def track(lane):
in_flight[lane] += 1
peak[lane] = max(peak[lane], in_flight[lane])
await asyncio.sleep(0.02)
# Hold until the expected overlap is reached, so a slow runner that
# starts the calls far apart cannot read as a lower peak.
deadline = asyncio.get_running_loop().time() + 5
while peak[lane] < want[lane] and asyncio.get_running_loop().time() < deadline:
await asyncio.sleep(0.005)
in_flight[lane] -= 1

async def propose(model, prompt):
Expand All @@ -3288,17 +3294,18 @@ async def summarize(model, prompt):
return '{"summary": "ok"}'
monkeypatch.setattr(pageindex.utils, "llm_acompletion", summarize)

def run(**kwargs):
def run(expected, **kwargs):
want.update(expand=expected[0], summary=expected[1])
peak.update(expand=0, summary=0)
flash_api.page_index_flash(str(pdf), summary_model="m", **kwargs)
return peak["expand"], peak["summary"]

assert run(summary_concurrency=1) == (1, 1)
assert run() == (3, 3) # control: the three overlap
assert run(summary=False, summary_concurrency=1) == (1, 0)
assert run(summary=False) == (3, 0)
assert run(optimize="merge", summary_concurrency=1) == (0, 1)
assert run(optimize="merge") == (0, 3)
assert (peak["expand"], peak["summary"]) == expected

run((1, 1), summary_concurrency=1)
run((3, 3)) # control: the three overlap
run((1, 0), summary=False, summary_concurrency=1)
run((3, 0), summary=False)
run((0, 1), optimize="merge", summary_concurrency=1)
run((0, 3), optimize="merge")


def test_count_tokens_falls_back_to_the_default_tokenizer(monkeypatch):
Expand Down
Loading