test: summary concurrency test waits for the expected overlap - #547
Merged
Merged
Conversation
test_summary_concurrency_caps_both_lanes_on_every_path held each mocked call for a fixed 20 ms and expected all three to overlap inside it. On a slow CI runner the three summaries start further apart than that, the first is gone before the third arrives, and the control run reads (3, 2) instead of (3, 3) (seen on py3.13 with frameworks). Each call still holds 20 ms, so an ungated lane still lets the others in, then holds until its lane reaches the expected peak (5 s deadline). Starting the summaries 15 ms apart reproduced (3, 2) before and passes now; an ignored cap still fails with (3, 3) == (1, 1), and too little overlap still fails with (2, 2) == (3, 3).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_summary_concurrency_caps_both_lanes_on_every_pathfailed on CI py3.13 (with frameworks) as(3, 2) == (3, 3)on three of #542's four commits, and passed on the fourth.The mock held each call for a fixed 20 ms and expected all three to overlap inside it. On a slow runner the three summaries start further apart than that, so the first one finishes before the third arrives.
Each call still holds 20 ms, so a lane with no cap still lets the others in. It then holds until its lane reaches the expected peak, with a 5 s deadline.
(3, 2)before this change and passes after it.(3, 3) == (1, 1)), and too little overlap still fails ((2, 2) == (3, 3)).Test-only change.