Repository navigation
feat(rollout): gate each ramp step on the new version's calls and errors - #89
Open
scott-lowe-vapi wants to merge 1 commit into
Open
scott-lowe-vapi wants to merge 1 commit into
scott-lowe-vapi wants to merge 1 commit into
Conversation
rollout.healthGate makes the ticker read each version's calls since the current step from /traffic-allocations/metrics before moving on: it waits for minCalls on the new version, then aborts the ramp (reason in the note) when its error rate is more than maxErrorRateDelta points above the old version's. Errors use the dashboard's rule, an ended reason that names an error. Part of DEPLOY-205. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support partial GitOps promotions using traffic splitting
Part of DEPLOY-205. 4 of 5 (optional): gate each ramp step on the new version's calls.
What changes
rollout.healthGate: { minCalls, maxErrorRateDelta }(defaults 20 and 2 points).GET /traffic-allocations/metrics(hourly buckets, window clamped to the endpoint's 2000-bucket cap). It waits forminCallson the new version, then aborts if the new version's error rate is more thanmaxErrorRateDeltapoints above the old one's.reason=error-rate+N.Npp. Reasons never reach PostHog: the event never sends the description.check:gate.Evidence
Config, decision (wait, pass, abort, no calls), the metrics read against a local stub, and the ticker's window are tested. 682 tests pass.
🤖 Generated with Claude Code