Repository navigation
feat(promote): pin assistants around the apply so a rollout org ramps instead of cutting over - #87
Open
scott-lowe-vapi wants to merge 1 commit into
Conversation
… instead of cutting over Into an org with rollout:, promote now pins each changed assistant to the version it serves, so the apply's publish lands at 0%, then writes the first ramp step (or undoes the pin when nothing was published). Pins are written before the apply child and resolved in a finally, so a failed apply never leaves an assistant stranded at 0% and never publishes one unpinned. A split set outside gitops or a Vapi for CX lock is refused up front; preflight runs again after a gate. --no-rollout publishes at once and releases gitops holds; --rollout-override pins over a manual split on its largest share. Part of DEPLOY-205. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Support partial GitOps promotions using traffic splitting
Part of DEPLOY-205. 2 of 5: promote into a rollout org pins, publishes at 0%, then takes step 1.
What changes
transitionRun(src/promote-cmd.ts), viasrc/rollout-promote.ts, for changed assistants that already exist in the destination:if (!apply) return falseand before thecheck:gate, so a refusal costs no simulation run and writes nothing. It refuses a split set outside gitops (a manual split wins) and a Vapi for CX lock, and skips assistants that 404 or have no version. If a gate ran, it runs again after the gate and beforepromotionPlanApply, because the gate can take 300 minutes while the ticker or an abort writes.finally: step 1 where a new version was published, or undo the pin (writing back exactly the row it replaced) where nothing was. An abort that landed meanwhile is left alone. The applied paths are recorded before any rollout error is thrown, so committed state always has its files.Also:
--no-rolloutpublishes at once and releases gitops holds on the assistants it published, which is the revert path.--rollout-override(single transition only) pins a manual split on its largest share, never the canary.gitops-rollout …marker (src/rollout-marker.ts), the ramp's only state.Evidence
tests/promote-rollout.test.tsdrivespromotionCommandRunagainst an in-memory allocation API with the platform's publish semantics (tests/rollout-fake.ts). It covers:targets;--no-rolloutvariants;631 tests pass.
🤖 Generated with Claude Code