[EmandM]

Purpose of this PR

When we generate the serialization code for NetworkVariables, we add code at the assembly level. Mono, for whatever reason, didn't complain if there were private or protected types in the serialization generation code. CoreCLR throws an error if we try to generate serialization for private types.

This PR detects this case and logs a warning in Mono, and an error in CoreCLR. This gives users a human-readable error message with information on how to fix the issue, and lets the code generation safely continue.

Jira ticket

UUM-156224

Changelog

• Fixed: NetworkVariable serialization now logs a clear error message when using CoreCLR and generating serialization for private or protected types.

Documentation

• No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

• Manual testing done

Automated tests:

• Covered by existing automated tests
• Covered by new automated tests

Does the change require QA team to:

• Review automated tests?
• Execute manual tests?
• Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

n/a

Backports

2.x doesn't need to support CoreCLR

[u-pr]

💡 Harness Review

The new diagnostics improve failure reporting, but the accessibility validation does not yet cover all supported serialization-generation contexts.

_{Reviewed commit 6624e66}

_{🤖 Helpful? 👍/👎}

[u-pr]

InitializeSerialization still fails on CoreCLR when NetworkVariable<Payload> uses a referenced base's protected internal nested enum without friend access. A derived NetworkBehaviour can legally declare that field using protected access. GetAllFieldsAndResolveGenerics collects Payload, but this predicate does not check IsNestedFamilyOrAssembly. The generated NetworkVariableSerializationHelper cannot access Payload because the helper is outside the base's assembly and inheritance hierarchy. Pass the consuming assembly into CollectTypesHiddenFromAssembly. Reject IsNestedFamilyOrAssembly types when that assembly lacks internal or friend access.

_{🤖 Helpful? 👍/👎}

[u-pr]

The warning/error decision can use the wrong backend when the editor and player runtimes differ. This #if uses the Editor-only ILPP assembly's compile-time defines, while assemblyDefines describes the assembly receiving the generated calls. The CI matrix includes Mono 6000.7 editors building CoreCLR players. If their ENABLE_CORECLR values differ, code generation only warns and retains calls that CoreCLR rejects. Select the branch using assemblyDefines.Contains("ENABLE_CORECLR").

_{🤖 Helpful? 👍/👎}

[codecov-github-com]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@              Coverage Diff               @@
##           develop-3.x.x    #4239   +/-   ##
==============================================
  Coverage          76.90%   76.90%           
==============================================
  Files                159      159           
  Lines              27663    27663           
==============================================
  Hits               21274    21274           
  Misses              6389     6389           

Flag	Coverage Δ
NGOv2_project_testproject_ubuntu	75.95% <ø> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Components	Coverage Δ
com.unity.netcode.gameobjects	76.90% <100.00%> (ø)

ℹ️ Need help interpreting these results?

[jabbacakes]

Suggested change

	## NetworkVariable serialization
	### NetworkVariable serialization

Just to make it clear that this is related to the CoreCLR stuff above.