Repository navigation
fix: FastBufferWriter growth from a size of 0 (up-port) - #4224
Merged
EmandM merged 4 commits intoOct 28, 2026
Merged
Conversation
A growable FastBufferWriter created with a size of 0 never returned from its first write that needed to grow: Grow doubled a capacity of 0, so its loop never reached the required size. Growth now starts from at least 1 byte. UUM-158589
2 of 6 tasks
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The change correctly allows zero-capacity writers to grow while preserving the existing maximum-capacity checks. I examined the growth and write paths, the regression test, surrounding growth tests, and the changelog; no actionable issues were found.
Reviewed commit 74aadc0
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-3.x.x #4224 +/- ##
=================================================
- Coverage 76.25% 76.20% -0.06%
=================================================
Files 159 159
Lines 27538 27576 +38
=================================================
+ Hits 21000 21013 +13
- Misses 6538 6563 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
|
ShadauxCat
approved these changes
Oct 27, 2026
EmandM
approved these changes
Oct 28, 2026
EmandM
enabled auto-merge (squash)
October 28, 2026 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Up-port of #4223.
A growable
FastBufferWritercreated with a size of 0 now grows on its first write, instead of never returning from it.Growdoubled a capacity of 0, so its loop never reached the required size; growth now starts from at least 1 byte.Jira ticket
UUM-158589
Changelog
FastBufferWritercreated with a size of 0 never returned from its first write orTryBeginWritecall that needed the buffer to grow.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?Up-port
N/A (this is the up-port)
Backports
#4223
🤖 Generated with Claude Code