Repository navigation
fix: FastBufferReader offset with the default length (up-port) - #4222
Merged
EmandM merged 3 commits intoOct 28, 2026
Merged
Conversation
A FastBufferReader created by copying a source with an offset and length -1 took the whole source length as its length, so it reported offset bytes too many and copied them from past the end of the source. Length -1 now means every byte after the offset when copying; Allocator.None, which reads the source in place starting at the offset, keeps the whole source length as before. The ArraySegment<byte> overload that takes an offset now applies it from the start of the segment instead of the start of the underlying array. UUM-158591
1 of 6 tasks
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The change correctly limits offset copies to the remaining source bytes and makes explicit ArraySegment offsets segment-relative. I examined constructor semantics, affected callers, regression tests, and release notes; no actionable issues were found.
Reviewed commit 5c2f8d0
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-3.x.x #4222 +/- ##
=================================================
- Coverage 76.25% 76.20% -0.06%
=================================================
Files 159 159
Lines 27538 27576 +38
=================================================
+ Hits 21000 21013 +13
- Misses 6538 6563 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ShadauxCat
approved these changes
Oct 27, 2026
EmandM
enabled auto-merge (squash)
October 28, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Up-port of #4221.
A
FastBufferReadercreated with an offset and the default length of -1 now reads exactly the bytes from the offset to the end of the source, instead of reportingoffsetextra bytes and copying them from past the end of the source. TheArraySegment<byte>overload that takes an offset now applies it from the start of the segment.Jira ticket
UUM-158591
Changelog
FastBufferReadercreated with an offset and the default length of -1 read past the end of its source. TheArraySegment<byte>overload that takes an offset now applies it from the start of the segment.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?Up-port
N/A (this is the up-port)
Backports
#4221