refactor: NetworkAnimator cleanup#4001
Open
noellie-velez wants to merge 3 commits into
Open
Conversation
simon-lemay-unity
approved these changes
May 28, 2026
Contributor
simon-lemay-unity
left a comment
simon-lemay-unity
left a comment
There was a problem hiding this comment.
Changes to UnityTransport are fine with me.
noellie-velez
force-pushed
the
refactor/network-animator-cleanup
branch
from
9ebf082 to
fa030ef
Compare
noellie-velez
changed the title
EmandM
reviewed
May 29, 2026
Member
EmandM
left a comment
EmandM
left a comment
There was a problem hiding this comment.
There's some really nice changes here. Only a few small comments
| { | ||
| if (IsServer) | ||
| { | ||
| /// <see cref="UpdatePendingTriggerStates"/> as to why we queue |
Member
There was a problem hiding this comment.
We probably still want these log lines, just with // rather than ///. We don't want to lose information.
Maybe move the comments into the XML doc for QueueTriggerUpdateToServer
| /// </summary> | ||
| /// <param name="animationTriggerMessage">the payload containing the trigger data to apply</param> | ||
| /// <param name="clientRpcParams">unused</param> | ||
| /// <param name="rpcParams"> unused</param> |
Member
There was a problem hiding this comment.
Technically this is used, it's just used in the RPC sending.
Suggested change
| /// <param name="rpcParams"> unused</param> | |
| /// <param name="rpcParams"> used to send the RPC to be invoked on this client</param> |
| /// to forward a trigger to a client | ||
| /// </summary> | ||
| /// <param name="animationTriggerMessage">the payload containing the trigger data to apply</param> | ||
| /// <param name="rpcParams"></param> |
Member
There was a problem hiding this comment.
Suggested change
| /// <param name="rpcParams"></param> | |
| /// <param name="rpcParams">Defined as it's used to send the RPC to be invoked on this client</param> |
| /// Optionally, you can still derive from <see cref="NetworkAnimator"/> and override the <see cref="OnIsServerAuthoritative"/> method. | ||
| /// </summary> | ||
| /// <returns><see cref="true"/> or <see cref="false"/></returns> | ||
| public bool IsServerAuthoritative() |
Member
There was a problem hiding this comment.
Hmmm, I know the tests are passing but we might need this defined to release seeing as it's a public function.
Suggested change
| public bool IsServerAuthoritative() | |
| /// <returns>True if this <see cref="NetworkAnimator"/> is server authoritative, false otherwise</returns> | |
| public bool IsServerAuthoritative() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Cleanup:
ContainsKeyandAddbyTryAddJira ticket
N/A
Changelog
N/A
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
N/A