fix: Prevent UseUnreliableDeltas from being used with SwitchTransformSpaceWhenParented#3875
Open
NoelStephensUnity wants to merge 9 commits intodevelop-2.0.0from
Conversation
Prevent user from selecting use unreliable deltas when SwitchTransformSpaceWhenParented is enabled (and vice versa). Adding check during runtime to also notify the user that this combination does not work (i.e. missed updates can result in a missed transform update when parenting changes).
EmandM
reviewed
Feb 9, 2026
Member
EmandM
left a comment
EmandM
left a comment
There was a problem hiding this comment.
Two nits:
- Should we use
NetworkLograther thanDebug? - It might be useful to have the
namein the log messages
EmandM
approved these changes
Feb 9, 2026
michalChrobot
approved these changes
Feb 9, 2026
…ble-certain-features
…ble-certain-features
jabbacakes
approved these changes
Feb 17, 2026
| - __Use Half Float Precision__ | ||
|
|
||
| > [!NOTE] | ||
| > **UseUnreliableDeltas** cannot be enabled if **SwitchTransformSpaceWhenParented** is enabled since **SwitchTransformSpaceWhenParented** requires deltas to be sent reliably. |
Contributor
There was a problem hiding this comment.
Suggested change
| > **UseUnreliableDeltas** cannot be enabled if **SwitchTransformSpaceWhenParented** is enabled since **SwitchTransformSpaceWhenParented** requires deltas to be sent reliably. | |
| > `UseUnreliableDeltas` cannot be enabled if `SwitchTransformSpaceWhenParented` is enabled because `SwitchTransformSpaceWhenParented` requires deltas to be sent reliably. |
| Things to consider when using __Switch Transform Space When Parented__: | ||
|
|
||
| - This property is synchronized by the authority instance. If you disable it on the authority instance then it will synchronize this adjustment on all non-authority instances. | ||
| - This property cannot be enabled when **UseUnreliableDeltas** is enabled as it requires deltas to be sent reliably. |
Contributor
There was a problem hiding this comment.
Suggested change
| - This property cannot be enabled when **UseUnreliableDeltas** is enabled as it requires deltas to be sent reliably. | |
| - This property cannot be enabled when `UseUnreliableDeltas` is enabled because it requires deltas to be sent reliably. |
|
|
||
| ### Fixed | ||
|
|
||
| - Fixed `NetworkTransform` issue where a user could enable UseUnreliableDeltas while SwitchTransformSpaceWhenParented was also enabled (and vice versa). (#3875) |
Contributor
There was a problem hiding this comment.
Suggested change
| - Fixed `NetworkTransform` issue where a user could enable UseUnreliableDeltas while SwitchTransformSpaceWhenParented was also enabled (and vice versa). (#3875) | |
| - Fixed `NetworkTransform` issue where a user could enable `UseUnreliableDeltas` while `SwitchTransformSpaceWhenParented` was also enabled (and vice versa). (#3875) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR adds additional
NetworkTransformeditor and runtime logic to prevent users from enablingUseUnreliableDeltaswhenSwitchTransformSpaceWhenParentedis enabled (and vice versa).When in the editor
If
UseUnreliableDeltasis enabled, thenSwitchTransformSpaceWhenParentedshould be disabled and read only with a message as to why:If
SwitchTransformSpaceWhenParentedis enabled, thenUseUnreliableDeltasshould be disabled and read only with a message as to why:Jira ticket
UUM-131540
fix: #3559
Changelog
NetworkTransformissue where a user could enableUseUnreliableDeltaswhileSwitchTransformSpaceWhenParentedwas also enabled (and vice versa).Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneNetworkTransformcomponent (or create one).UseUnreliableDeltas.SwitchTransformSpaceWhenParentedshould be disabled and read only.UseUnreliableDeltas.SwitchTransformSpaceWhenParented.UseUnreliableDeltasshould be disabled and read only.Automated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
No backport is required.