[ROS2] fix(server): avoid truncating JSON by removing unsafe UTF-8 slicing#176
Open
BG2EBZ wants to merge 1 commit intoUnity-Technologies:main-ros2from
Open
[ROS2] fix(server): avoid truncating JSON by removing unsafe UTF-8 slicing#176BG2EBZ wants to merge 1 commit intoUnity-Technologies:main-ros2from
BG2EBZ wants to merge 1 commit intoUnity-Technologies:main-ros2from
Conversation
…cation of JSON payload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cation of JSON payload
Proposed change(s)
This PR fixes a decoding issue in
server.pyfor the ROS 2 version of ROS–TCP–Endpoint.Previously, the line
message_json = data.decode("utf-8")[:-1]unconditionally removed the last byte of the incoming data.
The fix replaces it with:
message_json = data.decode("utf-8")Useful links (GitHub issues, JIRA tickets, forum threads, etc.)
Related issue: [ROS2] Proposed fix: unsafe UTF-8 slicing in server.py causes JSON truncation
Types of change(s)
Testing and Verification
The fix was verified using the Quest2ROS application. After applying this change, data were successfully transmitted and parsed between the Meta Quest 2 controllers and the ROS 2 (ROS–TCP Endpoint) over the same local network.
Test Configuration:
Checklist
devbranchdevbranchOther comments
This patch is a minimal bug fix.