Skip to content

feat(ui5-list): add InactiveSelectable list item type - #13962

Open
dobrinyonkov wants to merge 5 commits into
mainfrom
feat/list-item-type-inactive-selectable
Open

feat(ui5-list): add InactiveSelectable list item type#13962
dobrinyonkov wants to merge 5 commits into
mainfrom
feat/list-item-type-inactive-selectable

Conversation

@dobrinyonkov

@dobrinyonkov dobrinyonkov commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

related to: #13265, CS20260012870747

Summary

  • Adds InactiveSelectable as a new value to the ListItemType enum
  • Items of this type have no active press feedback and do not fire item-click (same as Inactive)
  • Unlike Inactive, selection (checkbox/radio) is still toggled when the list has a selectionMode set
  • Introduces a new isInactiveSelectable getter on ListItem for internal use

Usage

<ui5-list selection-mode="Multiple">
  <ui5-li type="InactiveSelectable">Selectable but inactive</ui5-li>
</ui5-list>

Behaviour

Active feedback item-click fires Selection toggles
Active
Inactive
InactiveSelectable
Navigation
Detail

Test plan

  • type="InactiveSelectable" with selection-mode="Multiple" — click/Space toggles checkbox, no item-click
  • type="InactiveSelectable" with selection-mode="Single" — click selects item, no item-click
  • type="InactiveSelectable" with selection-mode="None" — click does nothing
  • type="InactiveSelectable" with selection-mode="Delete" — click does nothing
  • type="Inactive" behavior unchanged
  • type="Active" behavior unchanged

Introduces a new `ListItemType.InactiveSelectable` enum value.
Items of this type behave like `Inactive` (no active press feedback,
no `item-click` event) but still allow selection (checkbox/radio)
to be toggled when the list has a selection mode set.
@dobrinyonkov
dobrinyonkov deployed to netlify-preview August 21, 2026 08:22 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown

👋 Heads-up: dev close is in effect

Thanks for the contribution! This repository is currently in dev close ahead of release 2.26 (scheduled 2026-08-26, UTC). See the release schedule for the full timeline.

This PR appears to introduce public-API changes (detected by diffing the Custom Elements Manifest against the latest published version on npm):

@ui5/webcomponents

  • ➕ added enum: ListItemType
  • ➕ added enum member: Active
  • ➕ added enum member: Detail
  • ➕ added enum member: Inactive
  • ➕ added enum member: InactiveSelectable
  • ➕ added enum member: Navigation
  • 🔄 changed attribute highlight (type)
  • 🔄 changed attribute type (type)

Could you please hold off on merging into main until the release ships? Public-API changes are best landed in the next dev cycle so they don't slip into the release at the last minute. Once the release is out, this PR is good to go.

If this change must ship in the current release, please request a review from one or two members of @UI5/ui5-team-webc so the team can sign off explicitly.

💬 False positive? If you believe this PR doesn't actually change the public API (e.g. only internal refactoring, or an entry the detector mis-attributed), please reply on this thread — your feedback helps us improve the detection during this trial run.

Posted automatically by the Dev Close Notice workflow.

@sap-ui5-webcomponents-release

Copy link
Copy Markdown

@dobrinyonkov
dobrinyonkov deployed to netlify-preview August 21, 2026 08:42 — with GitHub Actions Active
Cover the Enter keydown path through fireItemPress, which is a
distinct code path from Space (keyup) and click. Adds:
- Multiple + Enter toggles selection
- Single + Enter selects item
- item-click is NOT fired on Enter
@dobrinyonkov
dobrinyonkov deployed to netlify-preview August 21, 2026 10:19 — with GitHub Actions Active
@dobrinyonkov
dobrinyonkov deployed to netlify-preview August 21, 2026 10:21 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants