Skip to content

fix(ui5-list): add private selectionWhileInactive property - #13959

Closed
dobrinyonkov wants to merge 3 commits into
mainfrom
feat/selection-while-inactive
Closed

fix(ui5-list): add private selectionWhileInactive property#13959
dobrinyonkov wants to merge 3 commits into
mainfrom
feat/selection-while-inactive

Conversation

@dobrinyonkov

@dobrinyonkov dobrinyonkov commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a new private _selectionWhileInactive boolean property to ui5-list (default false)
  • When set, propagates to all list items via prepareListItems()
  • On ui5-li items with type="Inactive", clicking or using Space/Enter now toggles selection (checkbox/radio) without firing the item-click event

Usage

<ui5-list selection-mode="Multiple" _selection-while-inactive>
  <ui5-li type="Inactive">Item</ui5-li>
</ui5-list>

Test plan

  • Set type="Inactive" on list items with a selection mode — verify selection toggles on click/keyboard
  • Verify item-click is NOT fired for inactive items
  • Verify normal Active items are unaffected
  • Verify flag=false (default) preserves existing Inactive behavior

Adds a new private _selectionWhileInactive boolean property to ui5-list
(default false). When set, propagates to all list items via prepareListItems().

On ui5-li items with type="Inactive", clicking or using Space/Enter now
toggles selection (checkbox/radio) without firing the item-click event.

This lays the groundwork for a public API in the next major version.
@dobrinyonkov
dobrinyonkov deployed to netlify-preview August 20, 2026 12:57 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown

👋 Heads-up: dev close is in effect

Thanks for the contribution! This repository is currently in dev close ahead of release 2.26 (scheduled 2026-08-26, UTC). See the release schedule for the full timeline.

This PR appears to introduce public-API changes (detected by diffing the Custom Elements Manifest against the latest published version on npm):

@ui5/webcomponents

  • 🔄 changed attribute highlight (type)

Could you please hold off on merging into main until the release ships? Public-API changes are best landed in the next dev cycle so they don't slip into the release at the last minute. Once the release is out, this PR is good to go.

If this change must ship in the current release, please request a review from one or two members of @UI5/ui5-team-webc so the team can sign off explicitly.

💬 False positive? If you believe this PR doesn't actually change the public API (e.g. only internal refactoring, or an entry the detector mis-attributed), please reply on this thread — your feedback helps us improve the detection during this trial run.

Posted automatically by the Dev Close Notice workflow.

@sap-ui5-webcomponents-release

Copy link
Copy Markdown

@dobrinyonkov
dobrinyonkov deployed to netlify-preview August 20, 2026 13:13 — with GitHub Actions Active
@dobrinyonkov
dobrinyonkov deployed to netlify-preview August 20, 2026 13:16 — with GitHub Actions Active
@dobrinyonkov

Copy link
Copy Markdown
Contributor Author

FYI, @UI5/ui5-team-webc - this change is flagged as "introduces public-API changes" but it only adds a private member

@dobrinyonkov dobrinyonkov changed the title feat(ui5-list): add private _selectionWhileInactive property fix(ui5-list): add private _selectionWhileInactive property Aug 21, 2026
@dobrinyonkov dobrinyonkov changed the title fix(ui5-list): add private _selectionWhileInactive property fix(ui5-list): add private selectionWhileInactive property Aug 21, 2026
@dobrinyonkov

Copy link
Copy Markdown
Contributor Author

closing duo #13962

@dobrinyonkov
dobrinyonkov deployed to netlify-preview August 21, 2026 08:50 — with GitHub Actions Active
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

🧹 Preview deployment cleaned up: https://pr-13959--ui5-webcomponents.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant