Skip to content

test(runner): fix flaky redirect_error test under --parallel #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chemaclass merged 1 commit into from
Jul 14, 2026
Merged

test(runner): fix flaky redirect_error test under --parallel #796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions tests/unit/redirect_error_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,19 @@
#!/usr/bin/env bash
set -euo pipefail

_ERROR_LOG=temp_error.log

function tear_down() {
rm -f "$_ERROR_LOG"
}

function test_redirect_error_with_log() {
exec 2>&3 2>$_ERROR_LOG
# A per-test temp file, not a fixed name in CWD: under --parallel a shared
# filename races concurrent workers and intermittently reads empty/stale data.
local error_log
error_log=$(bashunit::temp_file redirect_error)
exec 2>&3 2>"$error_log"

local exit_code=0
_="$(render_into_error_fd_and_exit "arg1" "arg2")" || exit_code=$?
assert_same 1 "$exit_code"

local error_output
error_output=$(<$_ERROR_LOG)
error_output=$(<"$error_log")
assert_same "arg1 arg2" "$error_output"
}

Expand Down
Loading