test(runner): fix flaky redirect_error test under --parallel#796
Merged
Conversation
The test wrote to a fixed 'temp_error.log' in the working directory shared across tests and parallel workers, so a concurrent write/rm could race the read and yield empty/stale output (intermittent CI failure of 'Redirect error with log' in the Ubuntu parallel job). Use a per-test bashunit::temp_file, which is unique and auto-cleaned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
The "Redirect error with log" test intermittently failed in the Ubuntu parallel CI job. It wrote to a fixed
temp_error.login the working directory, shared across tests and parallel workers, so a concurrent write/rmcould race the read and yield empty/stale output. Not reproducible in isolation (0 failures across many parallel runs of the file alone).💡 Changes
bashunit::temp_file(unique, auto-cleaned) instead of a fixed shared filename, removing the parallel racetear_downcleanup of the shared file