Fix Dock mode switching and inactive saved bands - #22
Open
TheBeems wants to merge 3 commits into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c50c02eda
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…-switch # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching off Separate Dock items previously left saved separate IDs restorable alongside the combined band. Every usage refresh also replaced band objects and triggered a provider-wide host reload.
The provider now uses the active mode and visibility settings for both offered and restored bands. Band/page instances remain stable; inactive pages are emptied and notified, and normal updates refresh existing items without a provider-wide reload. Layout snapshots are published before synchronous host callbacks. Repeated display-property notifications also recover a host subscription that missed an initial update.
Validation:
36363df7e8051d279d6a1288fbb980ae95aa0b07: 371 x64 tests, x64 and ARM64 Debug builds with zero warnings/errors, and Store package validation.The host retains saved pins; changing modes does not automatically move or convert them. README and settings help explain adding the desired bands through Dock customization. The reported host COM failure had no stack trace, so these checks establish the extension fixes; the live click sequence remains a manual verification step.
Stacked on #21; no package identity, version, or COM registration changes. No merge or Store publication performed.