Skip to content

fix(release): wait for the release attestation before verifying it #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 2 commits into from
Oct 20, 2026
Merged

fix(release): wait for the release attestation before verifying it #3693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c4982e
fix(release): wait for the release attestation before verifying it
datlechin Oct 20, 2026
76709e8
docs(ci): name release/0.83 among the lines on the old checks
datlechin Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/rules/ci.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ paths:

- main and `release/*` require `CI`, the last job of `ci.yml`, and `PR title` (`pr-title.yml`). Strict is off. Admins can bypass in pull_request mode.
- `CI` fails when a job it needs failed or was cancelled. A skipped job passes.
- `release/0.82` keeps its own workflow files and the old per-workflow checks.
- `release/0.82` and `release/0.83` were cut before `ci.yml`: they keep their own workflow files and the old per-workflow checks (ruleset 23957966).
- Tags never move (ruleset 25308039, no bypass). Only admins create `release/*` and the `v*`, `ios-v*`, `linux-v*`, `libs-*` and `plugin-*` tags.

## Reading a red check
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,12 @@ jobs:
- name: Verify the release
run: |
set -euo pipefail
gh release verify "$TAG"
# GitHub writes the release attestation a few seconds after the release publishes.
for attempt in 1 2 3 4 5 6; do
gh release verify "$TAG" && break
[ "$attempt" -lt 6 ] || exit 1
sleep 10
done
for asset in dist/*; do
gh release verify-asset "$TAG" "$asset"
done
Expand Down
Loading