Repository navigation
Toggle play/pause with Center on the TV SeekBar - #148
Open
MattiasBuelens wants to merge 3 commits into
Open
MattiasBuelens wants to merge 3 commits into
MattiasBuelens wants to merge 3 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ceyhun-o
approved these changes
Oct 23, 2026
MattiasBuelens
added this pull request to stack #150
October 23, 2026 13:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TV
DefaultUIfocuses theSeekBarwhen the controls appear, so Left/Right seek right away. Until now, Center did nothing on the seek bar, so to pause you first had to move focus down to the play button. Google's "Playback controls on TV" guide says Center should toggle play/pause, so the TVSeekBarnow does that for Center, Enter and NumPad Enter.SeekBarState.togglePlayPause()inui-common. It plays or pauses the player. While the user is scrubbing, it doesn't touch the player and instead flips whether playback resumes inonValueChangeFinished(), so it doesn't fight the pause that scrubbing does.SeekBar(state)callsstate.togglePlayPause()on a KeyDown withrepeatCount == 0. Repeats from a held key are consumed but don't toggle again.tvHiddenControlsKeysconsumes the Center KeyDown: it shows the controls and toggles playback. The seek bar may get focus before the KeyUp arrives, and ignoring that KeyUp means playback isn't toggled a second time.Tests:
SeekBarStateTestcovers toggling normally and during a scrub.SeekBarTestcovers Center and Enter, holding Center, and a KeyUp without a KeyDown.DefaultUITestcovers Center on the focused seek bar, and a full Center press while the controls are hidden, which toggles exactly once.The TV guides and the changelog are updated.
Link to Devin session: https://dolby.devinenterprise.com/sessions/63210218adb6456ab0406d4eb65d28e9
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/63210218adb6456ab0406d4eb65d28e9?variant=devin
Requested by: @MattiasBuelens