Repository navigation
Debounce seeks while scrubbing the SeekBar - #149
Open
MattiasBuelens wants to merge 3 commits into
Open
MattiasBuelens wants to merge 3 commits into
MattiasBuelens wants to merge 3 commits into
Conversation
SeekBarState now extends PlaybackTimeState, so time displays can show the position being scrubbed to. UIController provides its SeekBarState to the default SeekBar and time display overloads. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ceyhun-o
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While scrubbing the
SeekBar,SeekBarState.onValueChangeused to setplayer.currentTimeon every position change: once per drag frame on mobile, and once per key repeat on TV. That loaded media for positions that were only scrubbed past.Now the player only seeks in two cases:
onValueChangeFinished). This seek is skipped if the debounced seek already went to the same position.seekTo(a single TV Left/Right press, or a tap) still seeks immediately.Without the intermediate seeks,
PlaybackTimeStatewouldn't know where the user is scrubbing to. To solve that,SeekBarStatenow extendsPlaybackTimeState:CurrentTimeDisplay(state = seekBarState)follows the thumb.UIControllerCoreremembers oneSeekBarStateand provides it asLocalUIControllerSeekBarState(@InternalUiApi).SeekBar()overloads use it throughrememberUIControllerSeekBarState(player).rememberPlaybackTimeState(player)returns it when it belongs to the same player.SeekBar()andCurrentTimeDisplay()inside aUIControllershare one state.Stacked on #148.
Link to Devin session: https://dolby.devinenterprise.com/sessions/63210218adb6456ab0406d4eb65d28e9
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/63210218adb6456ab0406d4eb65d28e9?variant=devin
Requested by: @MattiasBuelens