Fix Conductor validation coverage and document operational readiness - #6
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds Conductor readiness documentation, updates runtime boundary guidance, changes shell validation to check scripts individually, adds shell-validation coverage, and supplies a fake Herdr executable in runtime tests. ChangesReadiness and validation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The changes improve validation isolation and operational guidance without introducing an established merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
check:shellpreviously passed every script after the first as arguments to Bash instead of checking their syntax. Validate each entrypoint and add a regression for a later filename containing spaces, while proving scripts are never executed. Explicitly bind ten reconciliation test calls to their fake Herdr binary so an operator’sHERDR_BIN_PATHcannot change the test outcome.Update the Stage 3 cheatsheet, add first-run/readiness guidance, and link the canonical suite documentation. Package and manifest remain 0.4.0; product runtime authority is unchanged in this PR.
Validation at merged head
bf67d318067c60318dcd7089897f513bfefe3af7:npm run check: 542 tests passed, zero failures, with a deliberately nonexistent ambient Herdr path; all subsequent static/evidence checks passed.Base:
46d02c21352ad9ae6b3d6795775df56296ce516f. Merged head:bf67d318067c60318dcd7089897f513bfefe3af7. No effect/crash boundary changed; zero-CAS and retry negatives now reach their intended checks regardless of ambient binary selection. Runtime/security/private-state/role/source-evidence contracts retain their existing boundaries. Historical evidence was not regenerated or promoted as new live proof.Limitations remain cooperative same-UID records, final-check/pane-close TOCTOU, assertion-only worker results, retained resources, SHA-1-width Git, and no ambiguous-operation recovery outside the bounded Stage 3 apply publication. This PR did not add a new live installation claim. No adapter, unattended operation, cleanup, Browser integration, site code, product push/tag/release automation, CI configuration, or security-policy behavior change is included. Subsequent runtime fixes and developer smoke evidence are separate changes.