Fix post-apply stand-down and verify installed Herdr integration - #7
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a successful Stage 3 apply, the installed argument-free
stand-downaction failed withbookkeeping_unknown: its default abandonment reason is invalid for a terminal applied run. Default that state tonormal_completion; preserve every other default, explicit reason refusal, journal boundary, close-identity check, and archive/replay rule. A regression reproduces the original failure and verifies refusal without effects, completed archival, target retention, and effect-free replay.A fresh isolated Herdr 0.7.5 developer smoke reproduced the bug on
bf67d318and passed all seven installed actions on runtime candidate0f0e907742292b733d3bb8cf569096fbe265beba, including argument-free stand-down and replay. The dated developer smoke record records exact scope and limitations. This is bounded developer observation with synthetic work and operator-authored reports, not a formal independent-human release review or replacement for historical evidence.Update README and readiness guidance to distinguish this fresh bounded developer smoke from the separate formal release-evidence contract. Earlier validation/readiness changes are already merged in PR #6. Package/manifest remain 0.4.0 with exactly Herdr 0.7.5/protocol 17/schema 1 support.
Validation:
npm run check: 543/543 tests passed, zero failures, with all subsequent shell/Python/manifest/docs/historical-evidence checks passing. Both current final-head CI workflows (push and pull request) are fully green. Linux Node 20/LTS and macOS Node 20/system Bash 3.2 each pass 543 full-check tests and 497 explicit Stage 2/3 matrix tests, with zero failures.Base:
fb835bb6722a05ada181e766aea698fed683d50c(includes merged PR #6). Final head:ad170ee8e00be8979a7e1ae20bc6375e5e6f94d3. Runtime change is limited to selecting the already-legal default stand-down reason from the observed applied state. No new effect/crash/recovery boundary is introduced. Source/security/private-state/role contracts and historical evidence remain unchanged; the new developer record has its own path and does not assert validation by the formal release checker.Limitations remain cooperative same-UID records, final-check/pane-close TOCTOU, assertion-only worker results, retained resources, SHA-1-width Git, and no ambiguous-operation recovery outside the bounded Stage 3 apply publication. The fresh smoke does not prove adversarial same-UID isolation, autonomous model work, arbitrary workloads, or live crash recovery. No suite adapter, unattended operation, product cleanup, Browser integration, site code, push/tag/release automation, CI configuration, or security-policy behavior change is included. Suite website updates are separate.