Skip to content

swoc: fix big-endian IPv4 network-order helpers #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pkubaj wants to merge 2 commits into from
Closed

swoc: fix big-endian IPv4 network-order helpers #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b89407
swoc: fix big-endian IPv4 network-order helpers
pkubaj Nov 13, 2026
30bad9d
swoc: fix test_ip.cc to work on big-endian
pkubaj Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/include/swoc/swoc_ip_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,12 @@ inline bool is_loopback_network_order(in_addr_t addr) {
return is_loopback_host_order(addr);
}

inline bool is_link_local_network_order(inaddr_t addr) {
inline bool is_link_local_network_order(in_addr_t addr) {
return is_link_local_host_order(addr);
}

inline bool is_private_network_order(in_addr_t addr) {
return is_link_local_host_order(addr);
return is_private_host_order(addr);
}

inline bool is_multicast_network_order(in_addr_t addr) {
Expand Down
6 changes: 3 additions & 3 deletions unit_tests/test_ip.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,12 @@ TEST_CASE("Basic IP", "[libswoc][ip]") {
CHECK(ll4.is_link_local());
CHECK_FALSE(ll4.is_multicast());
CHECK(swoc::ip::is_link_local_host_order(ll4.host_order()));
CHECK_FALSE(swoc::ip::is_link_local_network_order(ll4.host_order()));
CHECK(swoc::ip::is_link_local_network_order(htonl(ll4.host_order())));

CHECK(swoc::ip::is_private_host_order(0xC0A8BADC));
CHECK_FALSE(swoc::ip::is_private_network_order(0xC0A8BADC));
CHECK(swoc::ip::is_private_network_order(htonl(0xC0A8BADC)));
CHECK_FALSE(swoc::ip::is_private_host_order(0xDCBA8C0));
CHECK(swoc::ip::is_private_network_order(0xDCBA8C0));
CHECK_FALSE(swoc::ip::is_private_network_order(htonl(0x0DCBA8C0)));

CHECK(IP4Addr(INADDR_LOOPBACK).is_loopback());

Expand Down