Repository navigation
Conversation
The big-endian branch of swoc_ip_util.h never compiled: the parameter of is_link_local_network_order() is spelled inaddr_t. Nobody noticed because until #11186 BYTE_ORDER and LITTLE_ENDIAN were both undefined there, so the little-endian branch got picked on every platform. Now a big-endian build (FreeBSD/powerpc64, 10.1.5) stops with swoc_ip_util.h:96:41: error: unknown type name 'inaddr_t' While there, is_private_network_order() in the same branch called the link-local check instead of is_private_host_order().
The test_ip.cc checks for these helpers fed host-order values to the network-order functions and only held on little-endian. Convert with htonl() so they pass on either byte order.
Collaborator
|
Sorry, my Claude mislead you. This is the github repo of our now departed friend Alan Carroll. No need to post this patch here or elsewhere. There is another repo for those who use the repo for things other than traffic server, but I merge stuff from apache/trafficserver to that other repo periodically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big-endian branch of swoc_ip_util.h never compiled: the parameter of is_link_local_network_order() is spelled inaddr_t. Nobody noticed because until #11186 BYTE_ORDER and LITTLE_ENDIAN were both undefined there, so the little-endian branch got picked on every platform. Now a big-endian build (FreeBSD/powerpc64, 10.1.5) stops with
swoc_ip_util.h:96:41: error: unknown type name 'inaddr_t'
While there, is_private_network_order() in the same branch called the link-local check instead of is_private_host_order().