Skip to content

refactor(scripts): inline Socket-override check in update-manifest #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
John-David Dalton (jdalton) merged 1 commit into from
Jul 11, 2026
+7 −3
Merged

refactor(scripts): inline Socket-override check in update-manifest #292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions scripts/npm/update-manifest.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { biomeFormat } from '../repo/util/biome.mts'
import { getModifiedFiles } from '../repo/util/git.mts'
import { fetchPackageManifest } from '@socketsecurity/lib-stable/packages/manifest'
import { resolveOriginalPackageName } from '@socketsecurity/lib-stable/packages/normalize'
import { isBlessedPackageName } from '@socketsecurity/lib-stable/packages/validation'
import { resolvePackageJsonEntryExports } from '@socketsecurity/lib-stable/packages/exports'
import { readPackageJson } from '@socketsecurity/lib-stable/packages/read'
import { extractPackage } from '@socketsecurity/lib-stable/packages/tarball'
Expand Down Expand Up @@ -85,15 +84,20 @@ export async function addNpmManifestData(manifest, options) {
await extractPackage(nmPkgId, async nmPkgPath => {
nmPkgJson = await readPackageJson(nmPkgPath, { normalize: true })
})
const isBlessed = isBlessedPackageName(data.name)
// Socket-maintained overrides take engines from the published
// package.json; third-party extensions keep the manifest's engines.
// (Inlined from the retired isBlessedPackageName helper.)
const isSocketOverride = data.name.startsWith('@socketregistry/')
manifestData.push([
PackageURL.fromString(
`pkg:${eco}/${data.name}@${nmPkgJson.version}`,
).toString(),
{
categories: nmPkgJson.socket?.categories ?? data.categories,
engines: filterEngines(
isBlessed ? (nmPkgJson.engines ?? data.engines) : data.engines,
isSocketOverride
? (nmPkgJson.engines ?? data.engines)
: data.engines,
),
interop: data.interop,
license: nmPkgJson.license ?? data.license,
Expand Down