Repository navigation
feat: the Guild tab shows spec, professions and reputations from the site when a member hasn't logged in - #13
Merged
Conversation
…site when a member hasn't logged in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Guild tab's member detail panel now falls back to Battle.net-sourced data from the site import (SQI1,
GameImportCharacter.spec/professions/reputations, additive) for spec, professions and tracked reputations -- the same patternitem_levelalready uses (websitebefe3e5-era_build_members_news_sheets_crafters, addonimportItemLevel).SideQuest.Data.REPUTATIONS(the tracked list) and shown in that list's order, asLabel: Standing (value/max); at Exalted, or when the import has nomax, just the standing word shows.Sync.lua/Codec.luaneed no changes -- the import payload'smembers[].characters[]is stored and read back opaquely, so the new fields just ride along once the site sends them.Testing
luajit tests/run_tests.lua-- 223 passed, 0 failed (includes 6 new tests intests/test_guild_battlenet_fallback.lua, alongside the existing 3 item-level tests).luacheck SideQuest tests-- 0 warnings / 0 errors.uv run --directory uploader pytest-- 17 passed.Depends on
Companion website PR adding
GameImportCharacter.spec/professions/reputationsto theSQI1:payload (seeSiteGuildDetailagent's PR). The companion app needs no change since it treatsSQI1:as opaque.