Repository navigation
feat: the addon's Guild tab shows spec, professions and reputations from Battle.net for members without the addon - #32
Merged
Conversation
…rom Battle.net for members without the addon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
spec,professions(name, skill, max_skill) andreputations(faction_id, standing 1–8, value, max) to eachGameImportCharacterin the SQI1 import. They come from the stored Battle.net sheet, with no new Battle.net calls and one query for the whole import. The sheet's reputation lines now storefaction_idandtier. Lines stored before this change are skipped until the character's next refresh (within 6h). Consumed by SideQuest-Guild/addon#13. The privacy page is updated.