Skip to content

Remove unused extension creation surface#8023

Open
isaacroldan wants to merge 1 commit into
remove-supports-atomic-deploymentsfrom
remove-create-extension-client-surface
Open

Remove unused extension creation surface#8023
isaacroldan wants to merge 1 commit into
remove-supports-atomic-deploymentsfrom
remove-create-extension-client-surface

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Remove the unused ensureThemeExtensionDevContext helper.
  • Delete the now-unused extension creation helper, GraphQL mutation, and client method surface.
  • Clean up tests and stubs that only covered the deleted path.

Validation:

  • pnpm vitest run packages/app/src/cli/services/context.test.ts packages/app/src/cli/services/context/id-matching.test.ts packages/app/src/cli/services/context/id-manual-matching.test.ts packages/app/src/cli/services/context/identifiers-extensions.test.ts packages/app/src/cli/services/dev/create-extension.test.ts
  • pnpm --filter app type-check
  • pnpm --filter app lint
  • pnpm knip

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 7, 2026
@isaacroldan isaacroldan force-pushed the remove-create-extension-client-surface branch from 69ad502 to f83503c Compare July 7, 2026 13:12
@isaacroldan isaacroldan force-pushed the remove-supports-atomic-deployments branch from 72408ba to 79bba2b Compare July 7, 2026 13:12
Assisted-By: devx/782ef931-ac0a-4cc4-bff1-a2511c379664
@isaacroldan isaacroldan force-pushed the remove-create-extension-client-surface branch from f83503c to 927308a Compare July 7, 2026 13:31
@isaacroldan isaacroldan force-pushed the remove-supports-atomic-deployments branch from 79bba2b to 0586551 Compare July 7, 2026 13:31
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -6,7 +6,6 @@ export declare const environmentVariables: {
     doctor: string;
     enableCliRedirect: string;
     env: string;
-    firstPartyDev: string;
     noAnalytics: string;
     optOutInstrumentation: string;
     appAutomationToken: string;
packages/cli-kit/dist/public/node/context/local.d.ts
@@ -63,13 +63,6 @@ export declare function alwaysLogAnalytics(env?: NodeJS.ProcessEnv): boolean;
  * @returns True if SHOPIFY_CLI_ALWAYS_LOG_METRICS is truthy.
  */
 export declare function alwaysLogMetrics(env?: NodeJS.ProcessEnv): boolean;
-/**
- * Returns true if the CLI User is 1P.
- *
- * @param env - The environment variables from the environment of the current process.
- * @returns True if SHOPIFY_CLI_1P is truthy.
- */
-export declare function firstPartyDev(env?: NodeJS.ProcessEnv): boolean;
 /**
  * Returns true if the CLI can run the "doctor-release" command.
  *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant