Skip to content

Remove deprecated draftable extension process#8018

Open
isaacroldan wants to merge 3 commits into
remove-shopify-cli-1p-devfrom
remove-draftable-extension-process
Open

Remove deprecated draftable extension process#8018
isaacroldan wants to merge 3 commits into
remove-shopify-cli-1p-devfrom
remove-draftable-extension-process

Conversation

@isaacroldan

Copy link
Copy Markdown
Contributor

Summary:

  • Remove the deprecated DraftableExtensionProcess fallback from app dev.
  • Delete the draft update helper and Partners update-draft GraphQL mutation surface it used.
  • Keep dev sessions as the only app preview update process when supported.

Validation:

  • pnpm vitest run packages/app/src/cli/services/dev/processes/setup-dev-processes.test.ts
  • pnpm --filter app type-check
  • pnpm --filter app lint

Assisted-By: devx/782ef931-ac0a-4cc4-bff1-a2511c379664
@isaacroldan isaacroldan requested review from a team as code owners July 7, 2026 08:48
@github-actions github-actions Bot added the Area: @shopify/app @shopify/app package issues label Jul 7, 2026

isaacroldan commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Assisted-By: devx/df67c0ff-0bc3-434a-b5d7-091c8efbac1e
Assisted-By: devx/df67c0ff-0bc3-434a-b5d7-091c8efbac1e
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -6,7 +6,6 @@ export declare const environmentVariables: {
     doctor: string;
     enableCliRedirect: string;
     env: string;
-    firstPartyDev: string;
     noAnalytics: string;
     optOutInstrumentation: string;
     appAutomationToken: string;
packages/cli-kit/dist/public/node/context/local.d.ts
@@ -63,13 +63,6 @@ export declare function alwaysLogAnalytics(env?: NodeJS.ProcessEnv): boolean;
  * @returns True if SHOPIFY_CLI_ALWAYS_LOG_METRICS is truthy.
  */
 export declare function alwaysLogMetrics(env?: NodeJS.ProcessEnv): boolean;
-/**
- * Returns true if the CLI User is 1P.
- *
- * @param env - The environment variables from the environment of the current process.
- * @returns True if SHOPIFY_CLI_1P is truthy.
- */
-export declare function firstPartyDev(env?: NodeJS.ProcessEnv): boolean;
 /**
  * Returns true if the CLI can run the "doctor-release" command.
  *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/app @shopify/app package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant