Select local E2E tests from the matrix - #705
Open
kieran-osgood-shopify wants to merge 2 commits into
Open
Conversation
| done | ||
|
|
||
| if [ "${#matches[@]}" -eq 0 ]; then | ||
| echo "Unknown E2E test file: $requested" >&2 |
Contributor
Author
There was a problem hiding this comment.
it'd be nice if we printed the known test file names
| MATRIX_INCLUDE_TAGS="$(printf '%s' "$application" | jq -r '.include_tags | join(",")')" | ||
| MATRIX_EXCLUDE_TAGS="$(printf '%s' "$application" | jq -r '.exclude_tags | join(",")')" | ||
|
|
||
| if [ "$HAS_EXPLICIT_TAGS" = true ]; then |
Contributor
Author
There was a problem hiding this comment.
how is smoke supposed to work here?
❯ dev react-native e2e ios --tags smoke
🔧 Running ./e2e/scripts/run_local_e2e react-native-ios "$@" from dev.yml
smoke is not enabled for react-native-ios
Enabled tags: launch,checkout
kieran-osgood-shopify
marked this pull request as ready for review
August 28, 2026 14:30
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
Assisted-By: devx/5f10c07c-0803-4f05-bc88-265174164e5a
Assisted-By: devx/5f10c07c-0803-4f05-bc88-265174164e5a
kieran-osgood-shopify
force-pushed
the
e2e-local-matrix-selection
branch
from
September 1, 2026 11:51
1a7a98b to
5b3a86c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Updating local
e2etest commands to usee2e/config/matrix.ymlas the source of truth for tests to run, ensuring they match what CI would run.What changes are you making?
Local E2E commands now:
dev <platform> e2ewith no tags/file names will run every matrix-enableddev <platform> e2e --tags <tag>dev <platform> e2e <filename>Key Points
dev <platform> e2e --tags smoke checkout-guestto run smoke and guest flowsHow to test
Green test
Theres two main things to test, you can select any of the tests listed for an application in the
matrix.ymlFor example there are 4 applications,
swift-ios/kotlin-android/react-native-androidandreact-native-iosEach of these should have the shared tags such as
smokeandlaunchSo you should be able to test that they do run if you pass that
Red Tests
However passing a tag that isn't supported, such as
preloadtoreact-native-*tests should failProviding an unknown filename should list the known test files:
