Describe E2E tests by focused coverage - #704
Open
kieran-osgood-shopify wants to merge 2 commits into
Open
Conversation
| end | ||
|
|
||
| def base_config | ||
| YAML.safe_load_file(MATRIX_PATH, aliases: true) |
Contributor
Author
There was a problem hiding this comment.
Every change to the matrix.yml was causing a cascade of required changes here asserting the structure of the yml, rather than the logic of whether the matrix expansion was happening correctly
Using a static object here we are less brittle to renames
kieran-osgood-shopify
marked this pull request as ready for review
August 28, 2026 13:39
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
Assisted-By: devx/5f10c07c-0803-4f05-bc88-265174164e5a
Assisted-By: devx/5f10c07c-0803-4f05-bc88-265174164e5a
kieran-osgood-shopify
force-pushed
the
e2e-feature-coverage-tags
branch
from
September 1, 2026 12:56
f13b9ce to
d0fe059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Changing the tagging methodology to simplify the opt in for a test
The duplication introduced in the include arrays will be rectified in: #703 where we make it additive for an application to declare tags
What
checkoutE2E selector with unique tags that name the primary regression each flow detectsios-onlyandandroid-onlyhttps://github.com/Shopify/checkout-kit/pull/705/changes works in concert with this PR to use the matrix expansion in local runs to narrow the possible tags available based on what we allow on CI
What changes are you making?
We had a broad
checkouttag on all checkout related tests, this proved awkward when it comes to calculating the include/exclude union of tagsWe split the
checkouttag into focused coverage tags because Maestro’s include-tag filtering uses OR not AND.If a test were tagged:
An application configured (in
matrix.yml) forcheckoutthat deliberately doesnt enablepreload(e.g. react-native) is now forced to run it, because it greedily matches the checkout.