Repository navigation
fix(automation): unify fact proposal contracts - #4541
Open
ScriptedAlchemy wants to merge 1 commit into
Open
ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
|
This was referenced Oct 25, 2026
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 25, 2026 10:26
b0a1c65 to
c6fdef1
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
from
October 25, 2026 10:26
92b5b28 to
6a3cba6
Compare
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 25, 2026 10:36
c6fdef1 to
8dfc5c0
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
from
October 25, 2026 10:36
03c5918 to
f1d2754
Compare
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 25, 2026 11:27
8c0b813 to
1827cd3
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
from
October 25, 2026 11:28
f1d2754 to
dec2b59
Compare
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 25, 2026 13:27
1827cd3 to
5d0ce78
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
from
October 25, 2026 13:27
dec2b59 to
bae3e41
Compare
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 25, 2026 19:42
800fb2c to
7fe08fa
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
2 times, most recently
from
October 25, 2026 19:43
0a88b9c to
702f2bc
Compare
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 25, 2026 20:06
7fe08fa to
872e5bf
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
from
October 25, 2026 20:06
702f2bc to
2ef3e13
Compare
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 26, 2026 03:43
4d0e36c to
bd30776
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
from
October 26, 2026 03:43
0bbf194 to
ef0ef3d
Compare
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 26, 2026 03:51
bd30776 to
0e3998c
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
from
October 26, 2026 03:51
ef0ef3d to
873386a
Compare
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 26, 2026 03:59
0e3998c to
ebf6fa0
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
from
October 26, 2026 03:59
873386a to
90fef52
Compare
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 26, 2026 05:15
ebf6fa0 to
09c814a
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
from
October 26, 2026 05:15
d467596 to
d4d1692
Compare
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 26, 2026 05:35
09c814a to
ea9438a
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
from
October 26, 2026 05:35
d4d1692 to
b8b3425
Compare
ScriptedAlchemy
force-pushed
the
fix/s2-4514-backlog-prefix-cache
branch
from
October 26, 2026 08:58
ea9438a to
c90e8f7
Compare
ScriptedAlchemy
force-pushed
the
fix/canonical-fact-proposals
branch
from
October 26, 2026 08:58
8005888 to
c658246
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #4478 first, followed by #4526, #4510, #4524, #4489, #4485, #4527, #4528, #4530, #4531, #4529, #4534, and #4541.
This PR is number 13 of 13, based on #4534.
Use merge commits. After merging a parent PR, change its child's base to
masterbefore merging the child. Auto-merge is disabled.Problem
Standalone session reflection, combined review, and runtime validation described the same fact proposal differently. In particular, combined review advertised string store IDs and numeric-only trust while runtime required numeric IDs and also accepted normalized trust labels. This made valid proposals depend on which route produced them.
Changes
tracedecay-contracts. Generate its inline JSON Schema with the existing Schemars dependency and embed it in both response envelopes.7.0normalize to7, while strings, fractions, and overflow are rejected.session_reflector:v3andcombined_review:v4.No dependency changes or public retained-evidence schema changes are needed. The accepted-item handoff remains the separate scope of #4430.
Validation
Cargo validation used the pinned nightly and retained production features, debug assertions, and overflow checks. All selected runs had nonzero test counts and no ignored or failed tests.
git diff --check, commitlint, and the existing generated BUILD-file check passed (61 generated files current).Native-storage fixtures ran in isolated temporary tmpfs directories and were removed afterward. No paid model calls were used.
The 61 passing tests cover this change on parent
ea18e44c202fcb1b0bf82156bd9f8fafd65b2502(the then-current #4529 head). The ten changed files are byte-identical after rebasing onto #4534 atb0a1c65b3e71f5ccbddfd3e25a39f4db2179056b. The intervening upstream changes are scheduler cancellation classification, structural-ID privacy handling, and status/doctor backlog-prefix memoization; none edits the fact-proposal contract or runner changes here.Final rebuild limitation: a recheck after the upstream privacy update rebuilt missing cached dependencies and was killed while compiling
asupersyncunder the 8 GiB container limit. It did not reach test execution. The 61 earlier passing tests are not presented as a run on the final stack parent. The last parent (#4534) was separately inspected: its single-file backlog-health cache change is outside these automation test paths.The earlier successful production-feature build used package-scoped compiler settings (
hint-mostly-unused, fewer LLVM names, and one frontend/backend job) to fit compilation into this container. These are local settings, not repository changes; they were also present in the final unsuccessful rebuild.Closes #4431