Skip to content

fix(config): retire unused sync controls - #4528

Open
ScriptedAlchemy wants to merge 1 commit into
fix/privacy-structured-key-coveragefrom
fix/retire-unused-sync-controls
Open

ScriptedAlchemy wants to merge 1 commit into
fix/privacy-structured-key-coveragefrom
fix/retire-unused-sync-controls

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

Merge #4478 first, followed by #4526, #4510, #4524, #4489, #4485, #4527, #4528, #4530, #4531, #4529, #4534, and #4541.

This PR is number 8 of 13, based on #4527. Merge #4530 next.

Use merge commits. After merging a parent PR, change its child's base to master before merging the child. Auto-merge is disabled.

Fixes #4434.

Why

sync.full_sync_escalation_files.v1 and sync.max_concurrent_syncs.v1 were listed, writable settings that no sync execution consumer read. They also remained required inputs when a resolved snapshot was materialized, so simply deleting their registry rows would break existing configuration.

Changes

  • Remove both runtime fields, defaults, materialization reads, active registry definitions, inventory entries, and public key exports.
  • Record their literal keys in the existing RETIRED_CORE_SETTING_KEYS_V1 authority. Project open already runs registry convergence before runtime pinning; saved defaults and overrides now converge into an immutable child revision while retaining unrelated values, provenance, and readable history.
  • Keep the released-key census and historical SQL fixture intact. Current settings lists omit both keys; reads and Set/Unset/Batch writes reject them with the existing unknown-setting validation result.
  • Add behavior coverage for discovery and write refusal, runtime pinning without the retired keys, persisted default/override convergence, history preservation, and reconvergence.

Caller audit

On the parent commit, exact field/key references were confined to runtime declarations/defaults/materialization, registry/default definitions, domain exports/inventory, and released configuration evidence. Generic discovery and mutation paths obtain supported definitions from ConfigurationRegistry, so there is no separate generated SDK/dashboard setting inventory to update.

The actual owners remain unchanged: scheduler concurrency uses background_reconcile_admission and MAX_CONCURRENT_RECONCILE_WORKTREES; capture/reuse decisions come from the scheduler's Git-tree/source-change reconciliation and full-capture fallback. Watcher opt-in, linked-worktree admission, timing/capacity, read-refresh/cooldown, and code-index worker budgets retain their existing owners.

Validation

Canonical Bazel validation on integrated parent commit c9de607ed5626290e105d4f131da459dc250e7a3:

  • Configuration unit tests: 40 passed, with formatting checks for configuration, domain, and global-db. Invocation 753c6565-2612-455f-ba61-d4bb0e20acdf.

  • Global-db configuration tests: 60 passed, including all three persisted retirement regressions, with the nonzero-test helper. Invocation 1a94cea4-f8ed-4ba7-8a01-acb7c89d21b6.

  • Scoped Clippy for the configuration and global-db unit-test targets passed: 4467346f-ead4-4303-b202-ffe4eddd81b8.

  • Maintained Bazel target-generation check passed: all 60 generated BUILD files are current (46bfaca8-36a0-4561-91ba-c94d49c08f9e).

  • All checks above used canonical Bazel targets with fresh Linux test results. Hosted checks remain independently required.

Stack

Based on #4527 (fix/privacy-structured-key-coverage). This layer contains only the configuration retirement and its regression coverage.

@changeset-bot

changeset-bot Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 603f723

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/privacy-structured-key-coverage branch from 96c2128 to 7cc565b Compare October 25, 2026 10:35
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/retire-unused-sync-controls branch from 35c547d to 33d47ea Compare October 25, 2026 10:35
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/privacy-structured-key-coverage branch from 7cc565b to 5f813ea Compare October 25, 2026 11:27
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/retire-unused-sync-controls branch from 33d47ea to 0edfed2 Compare October 25, 2026 11:27
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/privacy-structured-key-coverage branch from 5f813ea to f4bc0d4 Compare October 25, 2026 19:42
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/retire-unused-sync-controls branch from 0edfed2 to b9864dc Compare October 25, 2026 19:42
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/privacy-structured-key-coverage branch from f4bc0d4 to 1b16bf1 Compare October 25, 2026 20:06
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/retire-unused-sync-controls branch from b9864dc to 91804a5 Compare October 25, 2026 20:06
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/privacy-structured-key-coverage branch from a74f3e0 to 8df1317 Compare October 26, 2026 03:42
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/retire-unused-sync-controls branch from d368062 to 9cf7a68 Compare October 26, 2026 03:42
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/privacy-structured-key-coverage branch from 8df1317 to 55ff1db Compare October 26, 2026 03:51
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/retire-unused-sync-controls branch from 9cf7a68 to 4f5bbe9 Compare October 26, 2026 03:51
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/privacy-structured-key-coverage branch from 55ff1db to 792d797 Compare October 26, 2026 03:59
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/retire-unused-sync-controls branch from 4f5bbe9 to fa929ee Compare October 26, 2026 03:59
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/privacy-structured-key-coverage branch from 792d797 to dcbb4b6 Compare October 26, 2026 05:15
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/retire-unused-sync-controls branch from fa929ee to fb0786d Compare October 26, 2026 05:15
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/privacy-structured-key-coverage branch from dcbb4b6 to ab22321 Compare October 26, 2026 05:34
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/retire-unused-sync-controls branch from fb0786d to 25c2f98 Compare October 26, 2026 05:34
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/privacy-structured-key-coverage branch from ab22321 to ef1958c Compare October 26, 2026 08:58
Restack unique #4528 onto the rewritten #4527 tip.
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/retire-unused-sync-controls branch from 25c2f98 to 603f723 Compare October 26, 2026 08:58
ScriptedAlchemy added a commit that referenced this pull request Oct 26, 2026
Restack unique #4530 onto the rewritten #4528 tip.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant