Repository navigation
fix(config): retire unused sync controls - #4528
Open
ScriptedAlchemy wants to merge 1 commit into
Open
ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
|
This was referenced Oct 25, 2026
ScriptedAlchemy
force-pushed
the
fix/privacy-structured-key-coverage
branch
from
October 25, 2026 10:23
b7739ad to
96c2128
Compare
ScriptedAlchemy
force-pushed
the
fix/retire-unused-sync-controls
branch
from
October 25, 2026 10:24
45a1e69 to
35c547d
Compare
ScriptedAlchemy
force-pushed
the
fix/privacy-structured-key-coverage
branch
from
October 25, 2026 10:35
96c2128 to
7cc565b
Compare
ScriptedAlchemy
force-pushed
the
fix/retire-unused-sync-controls
branch
from
October 25, 2026 10:35
35c547d to
33d47ea
Compare
ScriptedAlchemy
force-pushed
the
fix/privacy-structured-key-coverage
branch
from
October 25, 2026 11:27
7cc565b to
5f813ea
Compare
ScriptedAlchemy
force-pushed
the
fix/retire-unused-sync-controls
branch
from
October 25, 2026 11:27
33d47ea to
0edfed2
Compare
ScriptedAlchemy
force-pushed
the
fix/privacy-structured-key-coverage
branch
from
October 25, 2026 19:42
5f813ea to
f4bc0d4
Compare
ScriptedAlchemy
force-pushed
the
fix/retire-unused-sync-controls
branch
from
October 25, 2026 19:42
0edfed2 to
b9864dc
Compare
ScriptedAlchemy
force-pushed
the
fix/privacy-structured-key-coverage
branch
from
October 25, 2026 20:06
f4bc0d4 to
1b16bf1
Compare
ScriptedAlchemy
force-pushed
the
fix/retire-unused-sync-controls
branch
from
October 25, 2026 20:06
b9864dc to
91804a5
Compare
ScriptedAlchemy
force-pushed
the
fix/privacy-structured-key-coverage
branch
from
October 26, 2026 03:42
a74f3e0 to
8df1317
Compare
ScriptedAlchemy
force-pushed
the
fix/retire-unused-sync-controls
branch
from
October 26, 2026 03:42
d368062 to
9cf7a68
Compare
ScriptedAlchemy
force-pushed
the
fix/privacy-structured-key-coverage
branch
from
October 26, 2026 03:51
8df1317 to
55ff1db
Compare
ScriptedAlchemy
force-pushed
the
fix/retire-unused-sync-controls
branch
from
October 26, 2026 03:51
9cf7a68 to
4f5bbe9
Compare
ScriptedAlchemy
force-pushed
the
fix/privacy-structured-key-coverage
branch
from
October 26, 2026 03:59
55ff1db to
792d797
Compare
ScriptedAlchemy
force-pushed
the
fix/retire-unused-sync-controls
branch
from
October 26, 2026 03:59
4f5bbe9 to
fa929ee
Compare
ScriptedAlchemy
force-pushed
the
fix/privacy-structured-key-coverage
branch
from
October 26, 2026 05:15
792d797 to
dcbb4b6
Compare
ScriptedAlchemy
force-pushed
the
fix/retire-unused-sync-controls
branch
from
October 26, 2026 05:15
fa929ee to
fb0786d
Compare
ScriptedAlchemy
force-pushed
the
fix/privacy-structured-key-coverage
branch
from
October 26, 2026 05:34
dcbb4b6 to
ab22321
Compare
ScriptedAlchemy
force-pushed
the
fix/retire-unused-sync-controls
branch
from
October 26, 2026 05:34
fb0786d to
25c2f98
Compare
ScriptedAlchemy
force-pushed
the
fix/privacy-structured-key-coverage
branch
from
October 26, 2026 08:58
ab22321 to
ef1958c
Compare
ScriptedAlchemy
force-pushed
the
fix/retire-unused-sync-controls
branch
from
October 26, 2026 08:58
25c2f98 to
603f723
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #4478 first, followed by #4526, #4510, #4524, #4489, #4485, #4527, #4528, #4530, #4531, #4529, #4534, and #4541.
This PR is number 8 of 13, based on #4527. Merge #4530 next.
Use merge commits. After merging a parent PR, change its child's base to
masterbefore merging the child. Auto-merge is disabled.Fixes #4434.
Why
sync.full_sync_escalation_files.v1andsync.max_concurrent_syncs.v1were listed, writable settings that no sync execution consumer read. They also remained required inputs when a resolved snapshot was materialized, so simply deleting their registry rows would break existing configuration.Changes
RETIRED_CORE_SETTING_KEYS_V1authority. Project open already runs registry convergence before runtime pinning; saved defaults and overrides now converge into an immutable child revision while retaining unrelated values, provenance, and readable history.Caller audit
On the parent commit, exact field/key references were confined to runtime declarations/defaults/materialization, registry/default definitions, domain exports/inventory, and released configuration evidence. Generic discovery and mutation paths obtain supported definitions from
ConfigurationRegistry, so there is no separate generated SDK/dashboard setting inventory to update.The actual owners remain unchanged: scheduler concurrency uses
background_reconcile_admissionandMAX_CONCURRENT_RECONCILE_WORKTREES; capture/reuse decisions come from the scheduler's Git-tree/source-change reconciliation and full-capture fallback. Watcher opt-in, linked-worktree admission, timing/capacity, read-refresh/cooldown, and code-index worker budgets retain their existing owners.Validation
Canonical Bazel validation on integrated parent commit
c9de607ed5626290e105d4f131da459dc250e7a3:Configuration unit tests: 40 passed, with formatting checks for configuration, domain, and global-db. Invocation
753c6565-2612-455f-ba61-d4bb0e20acdf.Global-db configuration tests: 60 passed, including all three persisted retirement regressions, with the nonzero-test helper. Invocation
1a94cea4-f8ed-4ba7-8a01-acb7c89d21b6.Scoped Clippy for the configuration and global-db unit-test targets passed:
4467346f-ead4-4303-b202-ffe4eddd81b8.Maintained Bazel target-generation check passed: all 60 generated BUILD files are current (
46bfaca8-36a0-4561-91ba-c94d49c08f9e).All checks above used canonical Bazel targets with fresh Linux test results. Hosted checks remain independently required.
Stack
Based on #4527 (
fix/privacy-structured-key-coverage). This layer contains only the configuration retirement and its regression coverage.