Skip to content

Remove the extraction folder also after a failed extraction #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnadareski merged 2 commits into from
Oct 16, 2026
Merged

Remove the extraction folder also after a failed extraction #424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ecbaab
Remove the extraction folder also after a failed extraction
gmipf Oct 16, 2026
3866d2b
Keep the original cleanup comment
gmipf Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions BinaryObjectScanner/Scanner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,11 +405,13 @@ private ProtectionDictionary GetInternalProtections(string fileName, Stream stre
// If we're scanning archives
if (_scanArchives && wrapper is IExtractable extractable)
{
// Get the output path
string tempPath = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());

// If the extractable file itself fails
try
{
// Extract and get the output path
string tempPath = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
// Extract to the output path
Directory.CreateDirectory(tempPath);
_ = extractable.Extract(tempPath, _includeDebug);

Expand All @@ -426,7 +428,13 @@ private ProtectionDictionary GetInternalProtections(string fileName, Stream stre
// Append the values
protections.Append(subProtections);
}

}
catch (Exception ex)
{
if (_includeDebug) Console.Error.WriteLine(ex);
}
finally
{
// If temp directory cleanup fails
try
{
Expand All @@ -438,10 +446,6 @@ private ProtectionDictionary GetInternalProtections(string fileName, Stream stre
if (_includeDebug) Console.Error.WriteLine(ex);
}
}
catch (Exception ex)
{
if (_includeDebug) Console.Error.WriteLine(ex);
}
}

#endregion
Expand Down
Loading