Skip to content

Remove the extraction folder also after a failed extraction - #424

Merged
mnadareski merged 2 commits into
SabreTools:masterfrom
gmipf:fix/extract-cleanup
Oct 16, 2026
Merged

mnadareski merged 2 commits into
SabreTools:masterfrom
gmipf:fix/extract-cleanup

Conversation

@gmipf

@gmipf gmipf commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

When Extract throws, for example because the temp folder is full, the cleanup is skipped and the partly extracted folder stays in the temp folder. This moves the cleanup into a finally.

Measured with ProtectionScan (net10.0, linux-x64) on the 817 MB data track of Star Wars: Episode I: Die dunkle Bedrohung (Germany) (Rerelease), on Ubuntu with /tmp as an 812 MB tmpfs:

  • master (055c793): the extraction fails and a 680 MB folder stays in /tmp
  • this branch: the extraction fails and nothing stays

With the temp folder on disk, both find Bitpool and write the same result file.

Prepared with AI assistance (Claude Opus 5.5) and reviewed before submission.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread BinaryObjectScanner/Scanner.cs Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mnadareski
mnadareski merged commit 0c23b23 into SabreTools:master Oct 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants