Skip to content

fix(stse_generate_random): fix overflow and improve documentation #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TofMassilia13320 merged 2 commits into from
Jun 5, 2026
+12 −7
Merged

fix(stse_generate_random): fix overflow and improve documentation #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09f5486
fix(stse_generate_random): fix index overflow and incorrect chunk inc…
parmi93 May 30, 2026
bb592c7
doc(stse_generate_random): fix random_size doxygen tag from [in,out] …
parmi93 May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions api/stse_random.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ stse_ReturnCode_t stse_generate_random(
return (STSE_API_HANDLER_NOT_INITIALISED);
}

if (random_size == 0) {
return (STSE_OK);
}

if (pRandom == NULL) {
return (STSE_API_INVALID_PARAMETER);
}
Expand All @@ -38,17 +42,18 @@ stse_ReturnCode_t stse_generate_random(
#ifdef STSE_CONF_STSAFE_L_SUPPORT
if (pSTSE->device_type != STSAFE_L010) {
#endif /* STSE_CONF_STSAFE_L_SUPPORT */
for (PLAT_UI16 index = 0; index < random_size;) {
ret = stsafea_generate_random(
pSTSE,
&pRandom[index],
((random_size - index) < STSAFEA_MAXIMUM_RNG_SIZE) ? (random_size - index) : STSAFEA_MAXIMUM_RNG_SIZE);
while (0 < random_size) {
PLAT_UI16 chunk = (random_size < STSAFEA_MAXIMUM_RNG_SIZE) ?
random_size : STSAFEA_MAXIMUM_RNG_SIZE;

ret = stsafea_generate_random(pSTSE, pRandom, chunk);

if (ret != STSE_OK) {
break;
}

index += STSAFEA_MAXIMUM_RNG_SIZE;
random_size -= chunk;
pRandom += chunk;
}
#ifdef STSE_CONF_STSAFE_L_SUPPORT
}
Expand Down
2 changes: 1 addition & 1 deletion api/stse_random.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
* \details This API use the STSE to generate random number
* \param[in] pSTSE Pointer to target STSecureElement device
* \param[in,out] pRandom Pointer to random buffer
* \param[in,out] random_size Random size
* \param[in] random_size Random size
* \return \ref STSE_OK on success ; \ref stse_ReturnCode_t error code otherwise
*/
stse_ReturnCode_t stse_generate_random(
Expand Down