fix(stse_generate_random): fix overflow and improve documentation#87
Merged
Conversation
…rement The previous implementation incremented the index by STSAFEA_MAXIMUM_RNG_SIZE even for the last chunk, which could cause an integer overflow and potentially an infinite loop when random_size is close to UINT16_MAX. Replaced index-based iteration with pointer arithmetic and random_size decrement to avoid overflow. Added early return STSE_OK for random_size == 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bug fix
The previous implementation incremented the index by
STSAFEA_MAXIMUM_RNG_SIZEeven for the last chunk, which could cause an integer overflow and potentially an infinite loop whenrandom_sizeis close toUINT16_MAX.Replaced index-based iteration with pointer arithmetic and
random_sizedecrement to avoid overflow. Added early returnSTSE_OKforrandom_size == 0.Documentation
Fixed incorrect Doxygen tag for
random_sizeparameter from[in,out]to[in].