Repository navigation
docs(skeep): SKEEP-003 status matches the code (#1500) - #1508
Open
michalharakal wants to merge 1 commit into
Open
michalharakal wants to merge 1 commit into
michalharakal wants to merge 1 commit into
Conversation
An audit at 0.64.0 found the old storage layer still in place beside the new one. The SKEEP goes back to Accepted and gains a status table per acceptance criterion and per open decision, linking the issues that track them. 003a, SKEEP-002, memory-model.adoc and the TensorStorage KDoc lose statements that later work made untrue. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
This was referenced Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1500. Part of #932.
SKEEP-003 was marked
Implemented, but an audit ofdevelopat 0.64.0 found the old storage layer still in place beside the new one. This PR changes records only; no behaviour changes.Status:back toAccepted, and a new Implementation status section with one table per acceptance criterion (two partly met, one not met, one without a baseline, one without a test) and one for the decisions that are open, each linked to its issue (SKEEP-003 acceptance guards: downcast guard, flat direct-memory test, benchmark baseline #1501, SKEEP-003 removals: LogicalDType, BufferHandle.Aliased, the old TensorView marker and SlicedTensorView, unused storage types #1502, SKEEP-003 decisions 3, 8 and 10: packed get() warning, axis labels on Shape, eager activation ids #1503, SKEEP-003: dispatch on Format instead of TensorData downcasts, loaders return views, TensorData as true façades #1507). Decisions 4, 5 and 7 are recorded as outside the SKEEP (scaledDotProductAttention and the backend attention kernels accept the windowed KV pair #1504, StableHLO export inserts the requant adapter a block encoding asks for #1505, Optional remote-IO module: HTTP range-request sources for SuspendingRandomAccessSource #1506); thegraph.Layoutdeprecation is left to SKEEP-004, which already schedules it.Resolvedis not a defined value and becomesImplemented.Draft.memory-model.adoc: the limit "packed weights still reach the managed heap" is narrowed to the formats it still applies to, and "TensorDataimplementations are façades over views" is worded as the code is.TensorStorageKDoc: no longer tells new loaders, planners and backends to target it.🤖 Generated with Claude Code