Repository navigation
refactor(lang-core): remove LogicalDType (#1502) - #1510
Open
michalharakal wants to merge 5 commits into
Open
michalharakal wants to merge 5 commits into
michalharakal wants to merge 5 commits into
Conversation
An audit at 0.64.0 found the old storage layer still in place beside the new one. The SKEEP goes back to Accepted and gains a status table per acceptance criterion and per open decision, linking the issues that track them. 003a, SKEEP-002, memory-model.adoc and the TensorStorage KDoc lose statements that later work made untrue. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
checkTensorDataDowncasts counts downcasts to concrete TensorData classes outside the data package against an allowlist that has to match the code exactly: 162 sites in 21 files today. It runs in the stub-markers CI leg. ForwardScopeFlatMemoryTest runs 300 forward passes under a forward scope on the JVM and asserts that direct memory, RSS and the slab stay flat. reference/benchmark-baseline.adoc records the JMH numbers a dispatch or storage change is compared against; scripts/pr-gate.sh points at it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
SKEEP-003 decision 13 merged the storage-side dtype enum into DType and deprecated it. TensorStorage and StorageMemoryReport now hold a DType directly instead of bridging to it from the enum, and the LogicalDType overloads of the storage factories are gone. No production code outside the storage package used the enum. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
…ryTest (#1501) RSS grew past the bound on a CI runner although nothing leaked: a JVM commits heap lazily, so RSS follows garbage that is already dead. The test now asserts the live heap after a collection and prints RSS. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…1502-remove-logical-dtype
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1502 (first of its removals) and #932.
Stacked on #1508 and #1509: until they merge, this PR also shows their commits. Review the last commit.
SKEEP-003 decision 13 merged the storage-side
LogicalDTypeenum intoDTypeand deprecated it in 0.49.0. The removal was planned for the next major; by maintainer decision (2026-11-11) it happens now.LogicalDType,LogicalDTypeBridge.kt(DType.toLogicalDType()) and their test are deleted.TensorStoragetook the enum as its real constructor field and computeddtypefrom it. It now takesdtype: DTypein the same position, so the dtype-first secondary constructor is no longer needed.StorageMemoryReportholdsdtype; itstoString()printsFloat32where it printedFLOAT32.LogicalDTypeoverloads ofTensorStorageFactory.fromRawBytes/fromRawBytesOwned/fileBackedandPackedBlockStorage.toTensorStorageare gone;toTensorStorage()keeps its no-argument form through a default ofFP32.logicalType = LogicalDType.FLOAT32todtype = FP32.Zero-consumer evidence: before the change, a search for
LogicalDType,logicalType,toLogicalDTypein main source sets outsidesk/ainet/lang/tensor/storagematched one KDoc comment inDType.kt. After it, the only match in Kotlin sources is that comment, reworded.This is a breaking change of the public API: the
skainet-lang-coredump loses 65 lines.Checked locally:
jvmTestfor lang-core, io-gguf and io-safetensors,apiCheck,checkUnmarkedStubs,checkTensorDataDowncasts, andassemblefor every target on this machine.🤖 Generated with Claude Code