Full rebuild September 2026 bump ros2-distro-mutex to 0.19.0 and build number to 23 - #41
Full rebuild September 2026 bump ros2-distro-mutex to 0.19.0 and build number to 23#41mini-1235 wants to merge 103 commits into
Conversation
|
I think bumping zenoh to 1.10.0 caused some issues with gazebo libraries; even on rolling (and even on the PR linked above) we seem to be still using 1.9.0. Reverting this to see how it goes. If you had a reason to bump zenoh up that I'm unaware of, we can seek alternative solutions. |
Reverting is fine with me. I originally bumped it to 1.10.0 because I wanted to test some of the new features, but I forgot that it could cause issues with Gazebo. My bad. |
|
Should we include #42 in this PR? |
Seems like a good idea. I guess I can just merge that branch in here and temporarily kill the caches for |
Co-authored-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
This reverts commit b3b623e.
| robostack: | ||
| linux: [libuuid] | ||
| osx: [] | ||
| osx: [libuuid] |
There was a problem hiding this comment.
Do we need this? MacOS has a native uuid implementation that I think is preferred. I remember something in the distant past about having issues with libuuid on osx.
There was a problem hiding this comment.
@mini-1235 can maybe answer that; I see in rolling this is not in there.
For my own education, would any cache need to be deleted if we revert this change?
There was a problem hiding this comment.
I think I was trying to remove this from #34:
https://github.com/wolfv/ros-lyrical/blob/0f9db906590d2880b4bef68c8e6fa78da017ecb4/patch/dependencies.yaml#L100-L103
since libuuid isn’t available on all platforms. But looking at it again, this might not actually be necessary. Let me temporarily remove nav2_map_server and see if the build succeeds.
There was a problem hiding this comment.
If reverted, perhaps append a comment. To prevent the same in the future.
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
00abcfa to
6127aa9
Compare
|
So MoveIt Task Constructor released a 0.2.0 version just last week with this change, and that's causing a bit of a stir-up on Windows as well. Making some changes now, and these will likely apply to other distros whenever we do rebuilds there. yay. Upstream PR in moveit/moveit_task_constructor#761 |
|
Build succeeded, but I got this error I'm unsure of on the Windows run at the very end: https://github.com/RoboStack/ros-lyrical/actions/runs/34427755718/job/102716901102?pr=41 I guess related to RoboStack/robostack.github.io#105? |
|
Maybe related to RoboStack/ros-rolling#34 I don't have my laptop now and I can't edit on my phone 😢 |
8f2050c to
57d9927
Compare
Thank you! It is related, but seemingly this is the first time it's needed to be done in But, we're all green here! Will let one of the maintainers give us the final go-ahead here. |
Supersedes #34 and #42