Move to src/ layout, add strict_types, add PHPStan to CI

.github/workflows/ci.yml

@@ -6,30 +6,24 @@ on:
   pull_request:
 
 jobs:
-  test:
+  tests:
+    name: Tests
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        php: [ '8.5' ]
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
+      - uses: actions/checkout@v6
+      - uses: shivammathur/setup-php@v2
         with:
-          php-version: ${{ matrix.php }}
+          php-version: '8.5'
+      - uses: ramsey/composer-install@v3
+      - run: composer phpunit
 
-      - name: Get composer cache
-        uses: actions/cache@v4
+  static-analysis:
+    name: Static Analysis
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: shivammathur/setup-php@v2
         with:
-          path: ~/.cache/composer
-          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-composer-
-
-      - name: Install dependencies
-        run: composer install --no-progress --prefer-dist --no-interaction
-
-      - name: Run PHPUnit
-        run: vendor/bin/phpunit --configuration phpunit.xml.dist
+          php-version: '8.5'
+      - uses: ramsey/composer-install@v3
+      - run: composer phpstan

composer.json

@@ -32,7 +32,12 @@
     },
     "autoload": {
         "psr-4": {
-            "Respect\\": "library/Respect"
+            "Respect\\Relational\\": "src/"
+        }
+    },
+    "autoload-dev": {
+        "psr-4": {
+            "Respect\\Relational\\": "tests/"
         }
     },
     "scripts": {

phpcs.xml.dist

@@ -11,7 +11,7 @@
     <arg value="p" />
     <arg value="s" />
 
-    <file>library/</file>
+    <file>src/</file>
     <file>tests/</file>
 
     <rule ref="Respect" />

phpstan.neon.dist

@@ -1,11 +1,15 @@
 parameters:
-  level: 1
+  level: 2
   paths:
-    - library/
+    - src/
     - tests/
   ignoreErrors:
-    - message: '/Call to an undefined static method Respect\\Relational\\Sql::\w+\(\)\./'
+    - message: '/Call to an undefined (static )?method Respect\\Relational\\(Sql|Db|Mapper)::\w+\(\)\./'
     - message: '/Call to an undefined static method Respect\\Data\\Collections\\(Collection|Filtered|Mix|Typed)::\w+\(\)\./'
+    - message: '/Access to an undefined property Respect\\Relational\\Mapper::\$\w+\./'
     - message: '/Unsafe usage of new static\(\)\./'
     - message: '/Cannot unset property .+ because it might have hooks in a subclass\./'
     - message: '/Array has \d+ duplicate keys/'
+    -
+      message: '/unknown class/'
+      path: tests/Styles/

phpunit.xml.dist

@@ -11,7 +11,7 @@
   </testsuites>
   <source>
     <include>
-      <directory>library/</directory>
+      <directory>src/</directory>
     </include>
   </source>
 </phpunit>

library/Respect/Relational/Db.php → src/Db.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Relational;
 
 use PDO;

library/Respect/Relational/Mapper.php → src/Mapper.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Relational;
 
 use Exception;
@@ -452,6 +454,10 @@ protected function parseCollection(
 
     protected function hasComposition($entity, $next, $parent)
     {
+        if ($next === null || $parent === null) {
+            return false;
+        }
+
         $s = $this->getStyle();
 
         return $entity === $s->composed($parent, $next)
@@ -647,7 +653,8 @@ protected function getAllProperties($object)
         $cols = get_object_vars($object);
         $ref = new \ReflectionClass($object);
         foreach ($ref->getProperties() as $prop) {
-            if (preg_match('/@Relational\\\isNotColumn/', $prop->getDocComment())) {
+            $docComment = $prop->getDocComment();
+            if ($docComment !== false && preg_match('/@Relational\\\isNotColumn/', $docComment)) {
                 continue;
             }
             $cols[$prop->name] = $prop->getValue($object);

library/Respect/Relational/Sql.php → src/Sql.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Relational;
 
 class Sql
@@ -224,7 +226,7 @@ protected function normalizeParts($parts, $raw = false)
         array_walk_recursive($parts, function ($value, $key) use (&$newParts, &$params, &$raw) {
                 if ($value instanceof Sql) {
                     $params = array_merge($params, $value->getParams());
-                    if (0 !== stripos($value, '(')) {
+                    if (0 !== stripos((string) $value, '(')) {
                         $value = Sql::enclose($value);
                     }
                     $newParts[$key] = $value;

tests/library/Respect/Relational/DbTest.php → tests/DbTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Relational;
 
 class DbTest extends \PHPUnit\Framework\TestCase

tests/library/Respect/Relational/MapperTest.php → tests/MapperTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Relational;
 
 use PDO;

tests/library/Respect/Relational/SqlTest.php → tests/SqlTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Relational;
 
 class SqlTest extends \PHPUnit\Framework\TestCase

tests/library/Respect/Relational/Styles/AbstractStyleTest.php → tests/Styles/AbstractStyleTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Data\Styles;
 
 class AbstractStyleTest extends \PHPUnit\Framework\TestCase

tests/library/Respect/Relational/Styles/CakePHPTest.php → tests/Styles/CakePHPTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Data\Styles\CakePHP;
 
 use PDO,

tests/library/Respect/Relational/Styles/NorthWindTest.php → tests/Styles/NorthWindTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Data\Styles\NorthWind;
 
 use PDO,

tests/library/Respect/Relational/Styles/PluralTest.php → tests/Styles/PluralTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Data\Styles\Plural;
 
 use PDO,

tests/library/Respect/Relational/Styles/SakilaTest.php → tests/Styles/SakilaTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Data\Styles\Sakila;
 
 use PDO,

tests/library/Respect/Relational/Styles/StandardTest.php → tests/Styles/StandardTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Respect\Data\Styles;
 
 class StandardTest extends \PHPUnit\Framework\TestCase