Move to src/ layout, add strict_types, add PHPStan to CI#90
Merged
alganet merged 1 commit intoRespect:masterfrom Mar 15, 2026
Merged
Move to src/ layout, add strict_types, add PHPStan to CI#90alganet merged 1 commit intoRespect:masterfrom
alganet merged 1 commit intoRespect:masterfrom
Conversation
Member
alganet
commented
Mar 15, 2026
alganet
commented
- Move source from library/Respect/Relational/ to src/ and tests from tests/library/Respect/Relational/ to tests/. Update PSR-4 autoload to Respect\Relational\ -> src/ with autoload-dev for tests.
- Add declare(strict_types=1) to all 12 PHP files. This surfaced two bugs: Mapper::getAllProperties() passing false to preg_match when getDocComment() returns false, and Sql::normalizeParts() passing a Sql object to stripos() instead of a string. Both fixed.
- Raise PHPStan to level 2 with ignores for magic methods, properties, and Style test namespace resolution.
- Modernize CI: split into tests and static-analysis jobs, update to actions/checkout@v6 and ramsey/composer-install@v3.
- Move source from library/Respect/Relational/ to src/ and tests from tests/library/Respect/Relational/ to tests/. Update PSR-4 autoload to Respect\Relational\ -> src/ with autoload-dev for tests. - Add declare(strict_types=1) to all 12 PHP files. This surfaced two bugs: Mapper::getAllProperties() passing false to preg_match when getDocComment() returns false, and Sql::normalizeParts() passing a Sql object to stripos() instead of a string. Both fixed. - Raise PHPStan to level 2 with ignores for magic methods, properties, and Style test namespace resolution. - Modernize CI: split into tests and static-analysis jobs, update to actions/checkout@v6 and ramsey/composer-install@v3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.