Skip to content

fix(sell): re-quote via the sell price endpoint on currency change #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuakrueger-dfx wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(sell): re-quote via the sell price endpoint on currency change #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/screens/sell/cubits/sell_converter/sell_converter_cubit.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,15 @@ class SellConverterCubit extends Cubit<SellConverterState> {
// the seq guard.
emit(state.copyWith(loading: true, currency: currency));
try {
final result = await _brokerbotService.getBuyPrice(state.sharesText, currency);
// Sell flow: a currency switch must re-quote via the SELL price endpoint
// (estimatedAmount = what the user receives), mirroring _convertShares.
// It previously called getBuyPrice/totalCost, showing a buy-side quote
// as the "You receive" amount (issue #657 P4 S1).
final result = await _brokerbotService.getSellPrice(state.sharesText, currency);
if (isClosed || mySeq != _seq) return;
emit(
state.copyWith(
fiatText: result.totalCost.toStringAsFixed(_fractionDigits(state.sharesText)),
fiatText: result.estimatedAmount.toStringAsFixed(_fractionDigits(state.sharesText)),
loading: false,
),
);
Expand Down
28 changes: 20 additions & 8 deletions test/screens/sell/cubits/sell_converter_cubit_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,12 @@ void main() {
expect(cubit.state.fiatText, '125.50');
});

test('onCurrencyChanged calls getBuyPrice (not getSellPrice) with current shares', () async {
// Note: the cubit uses BUY price for currency switch (likely on purpose
// to convert the displayed share count to a fiat estimate without the
// sell-side fee deduction). This test pins that contract.
test(
'onCurrencyChanged re-quotes via the SELL price endpoint '
'(issue #657 P4 S1 regression — used to call getBuyPrice)', () async {
// The previous behaviour called getBuyPrice/totalCost on a currency
// switch, rendering a buy-side quote as the sell "You receive" amount —
// inconsistent with onSharesChanged, which quotes via getSellPrice.
when(() => service.getBuyPrice(any(), any())).thenAnswer(
(_) async => BrokerbotBuyPriceDto(
totalCost: 50.0,
Expand All @@ -182,16 +184,26 @@ void main() {
await cubit.onSharesChanged('10');
await Future<void>.delayed(const Duration(milliseconds: 250));

when(() => service.getSellPrice(any(), any())).thenAnswer(
(_) async => BrokerbotSellPriceDto(
shares: 10,
estimatedAmount: 95.5,
pricePerShare: 9.55,
currency: 'EUR',
),
);
await cubit.onCurrencyChanged(Currency.eur);

expect(cubit.state.currency, Currency.eur);
expect(cubit.state.fiatText, '50.00');
verify(() => service.getBuyPrice('10', Currency.eur)).called(1);
// Sell-side estimate, NOT the buy-side totalCost (50.00).
expect(cubit.state.fiatText, '95.50');
verify(() => service.getSellPrice('10', Currency.eur)).called(1);
verifyNever(() => service.getBuyPrice(any(), any()));
});

test('onCurrencyChanged flips currency even when getBuyPrice throws', () async {
test('onCurrencyChanged flips currency even when the sell quote throws', () async {
when(
() => service.getBuyPrice(any(), any()),
() => service.getSellPrice(any(), any()),
).thenAnswer((_) async => throw Exception('throttle'));

final cubit = SellConverterCubit(service);
Expand Down
Loading