fix(sell): re-quote via the sell price endpoint on currency change#680
Open
joshuakrueger-dfx wants to merge 1 commit into
Open
fix(sell): re-quote via the sell price endpoint on currency change#680joshuakrueger-dfx wants to merge 1 commit into
joshuakrueger-dfx wants to merge 1 commit into
Conversation
onCurrencyChanged called getBuyPrice and rendered totalCost as the sell "You receive" amount — a buy-side quote on the Sell screen, inconsistent with onSharesChanged (which quotes via getSellPrice/estimatedAmount). Switch to the sell endpoint so the displayed amount matches what the user actually receives. The previous unit test pinned the getBuyPrice call as "likely on purpose"; that assumption was wrong (it contradicts the sell-conversion path) and is rewritten to assert the sell endpoint. Regression: test/screens/sell/cubits/sell_converter_cubit_test.dart Issue RealUnitCH#657 — Part 4, finding S1 (HIGH).
joshuakrueger-dfx
force-pushed
the
joshua/fix-657-p4s1-sell-endpoint
branch
from
4d1649a to
5d500d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #657 — Part 4, finding S1 (HIGH).
Problem
onCurrencyChangedcalledgetBuyPriceand renderedtotalCostas the sell "You receive" amount — a buy-side quote on the Sell screen, inconsistent withonSharesChangedwhich quotes viagetSellPrice/estimatedAmount.Fix
Switch the currency-change re-quote to
getSellPrice+estimatedAmount.Note on the existing test
The prior unit test pinned
getBuyPriceas "likely on purpose" — that assumption contradicts the sell-conversion path and is rewritten to assert the sell endpoint (verify(getSellPrice)+verifyNever(getBuyPrice)).Tests (RED→GREEN, proven)
Rewritten contract test fails on the old code, passes with the fix. Suite 14/14 green,
flutter analyzeclean.🤖 Big Brother fleet flagged + operator hand-finish. Ref #657.