Skip to content

Fix non-trivial compiler warnings #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anf3is wants to merge 5 commits into
base: reactivedrop_beta
Choose a base branch
from
Open

Fix non-trivial compiler warnings #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f8f3a1
fix!: change type from int to bool for boolean member of CAttachmentData
anf3is Sep 28, 2026
65331cb
fix!: remove unused bool success
anf3is Sep 28, 2026
0460ec3
fix!: set calculated coverGoal for navigator
anf3is Sep 29, 2026
57edae5
fix!: change member value of CCvarSlider instead of local redefinition
anf3is Sep 28, 2026
08c5b0b
hide warning C4456: declaration of 'VProf_' hides previous local decl…
anf3is Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/game/client/c_baseanimating.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class CAttachmentData
QAngle m_angRotation;
Vector m_vOriginVelocity;
int m_nLastFramecount : 31;
int m_bAnglesComputed : 1;
bool m_bAnglesComputed : true;
};


Expand Down
2 changes: 1 addition & 1 deletion src/game/client/swarm/gameui/cvarslider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ void CCvarSlider::Reset()
m_iLastSliderValue = m_iStartValue;
return;
}
float m_fStartValue = var.GetFloat();
m_fStartValue = var.GetFloat();
m_fCurrentValue = m_fStartValue;

int value = (int)( CVARSLIDER_SCALE_FACTOR * m_fStartValue );
Expand Down
8 changes: 7 additions & 1 deletion src/game/client/viewrender.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5131,7 +5131,10 @@ bool DrawingShadowDepthView( void ) //for easy externing
{
return (CurrentViewID() == VIEW_SHADOW_DEPTH_TEXTURE);
}


#ifdef _WIN32
#pragma warning (disable:4456) // hide 'declaration of 'VProf_' hides previous local declaration'
#endif
//-----------------------------------------------------------------------------
//
//-----------------------------------------------------------------------------
Expand Down Expand Up @@ -5220,6 +5223,9 @@ void CShadowDepthView::Draw()
#endif
}

#ifdef _WIN32
#pragma warning (default:4456)
#endif

//-----------------------------------------------------------------------------
//
Expand Down
3 changes: 1 addition & 2 deletions src/game/server/ai_basenpc_schedule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2167,8 +2167,7 @@ void CAI_BaseNPC::StartTask( const Task_t *pTask )
AIN_DEF_FLAGS,
m_hStoredPathTarget );

// TODO: is this a bug? why goal and not coverGoal?
foundPath = GetNavigator()->SetGoal( goal );
foundPath = GetNavigator()->SetGoal( coverGoal );

m_flMoveWaitFinished = gpGlobals->curtime + pTask->flTaskData;
}
Expand Down
1 change: 0 additions & 1 deletion src/game/server/nav_generate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1596,7 +1596,6 @@ static bool testStitchConnection( CNavArea *source, CNavArea *target, const Vect
else
{
// test going up ClimbUpHeight
bool success = false;
for ( float height = StepHeight; height <= ClimbUpHeight; height += 1.0f )
{
trace_t tr;
Expand Down