Skip to content

fix(examine): report amdkfd_loaded and amdgpu_loaded when built into the kernel #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomastola wants to merge 19 commits into
base: main
Choose a base branch
from
Open

fix(examine): report amdkfd_loaded and amdgpu_loaded when built into the kernel #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0329d96
fix(examine): report amdkfd_loaded when kfd is built into the kernel
tomastola Oct 15, 2026
4a1414d
test(examine): cover the amdkfd_loaded wiring and the kfd scenarios
tomastola Oct 15, 2026
8ecd070
refactor(examine): decide amdkfd_loaded at a single call site
tomastola Oct 15, 2026
ea4b420
docs(examine): say what amdkfd_loaded means now
tomastola Oct 16, 2026
7a366fa
fix(examine): report amdgpu_loaded when amdgpu is built into the kernel
tomastola Oct 16, 2026
a02b0af
refactor(examine): share one module-or-host check; kfd on the host im…
tomastola Oct 26, 2026
bf58a98
test(examine): renumber the built-in amdgpu scenario to examine-33
tomastola Oct 27, 2026
7071210
fix(examine): take a built-in amdgpu from the PCI driver, not /sys/mo…
tomastola Oct 27, 2026
d7652d0
test(examine): pin that kfd on the host alone implies amdgpu_loaded
tomastola Oct 27, 2026
22bc07f
docs(examine): say kfd is linked into amdgpu on current kernels only
tomastola Oct 27, 2026
c5ebdd8
test(examine): match each amdgpu-missing evidence line verbatim
tomastola Oct 27, 2026
4a758f7
test(examine): pin which host signal answers which driver field
tomastola Oct 27, 2026
be07af9
test(examine): cover kfd answering both drivers with no module list
tomastola Oct 27, 2026
b99e9ac
docs: list the driver-presence reads behind the simulated host root
tomastola Oct 27, 2026
66c3734
test(examine): share the fake-executable PATH fixture
tomastola Oct 27, 2026
a2ac4d1
test(examine): hand the wiring tests their module list
tomastola Oct 28, 2026
7e406af
test(examine): pin the module-list names in driver_states
tomastola Oct 30, 2026
6c8661c
test(examine): hold the host-root lock in the repo-scan tests
tomastola Oct 30, 2026
50224ab
ci: count the three probe_modules_reports tests in the host-root comment
tomastola Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,11 @@ jobs:
# fields and the distro name, in
# `os_release_reads_follow_the_simulated_host_root` and, for the
# `/usr/lib/os-release` fallback, in
# `os_release_reads_fall_back_to_usr_lib_when_etc_is_absent`). The other routed
# `os_release_reads_fall_back_to_usr_lib_when_etc_is_absent`), and the
# driver-presence reads `/sys/class/kfd/kfd`, `/dev/kfd` and
# `/sys/bus/pci/drivers/amdgpu` (`kfd_present_on_host`,
# `amdgpu_present_on_host`, `driver_states` and the three
# `probe_modules_reports_*` tests). The other routed
# reads (`/dev/dri`, `/sys/class/drm`, `/sys/module/amdgpu`, the other
# `/proc` files, the modprobe directories, the `/usr/lib/wsl/lib` and
# ROCDXG checks) have no planted-root unit assertion; they are covered
Expand Down
Loading
Loading