Repository navigation
test(archive-props): pin that an absolute-named symlink keeps its target - #692
Merged
Merged
Conversation
moved_one_level_down returns an entry with an absolute name untouched, before it looks at a symlink target. No case combined an absolute name with a symlink, so hoisting the target's ../ above that early return stayed green. Add one per absolute spelling. Signed-off-by: Roman Inflianskas <Roman.Inflianskas@amd.com>
juhovainio
approved these changes
Oct 15, 2026
juhovainio
left a comment
juhovainio
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the diff (via gh pr diff, no checkout). This is a small, test-only addition (+13/-0) that closes a Gherkin/e2e coverage gap left by #684. Both a line-by-line code review and a separate standards/spec pass came back clean - no blocking or non-blocking findings. The new coverage is scoped correctly and doesn't touch any production code paths.
Approving based on the diff read. CI had some GPU/hardware lanes still pending at last check - worth confirming those land green before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #684, for the automated review's non-blocking note there.
moved_one_level_downreturns an entry with an absolute name untouched. It does this before it looks at a symlink target. No test combined an absolute name with a symlink, so a change that hoisted the target's../above that early return stayed green.moving_an_entry_down_keeps_its_symlink_target_in_placenow moves a symlink with each absolute name spelling (/xand@OUT/x) and a relative target. It asserts that both the name and the target are unchanged. With the../splice moved above the name check, the test fails with "target of /x was rewritten".Test-only change: no user-observable CLI behaviour changes, so no Gherkin scenario is needed (AGENTS.md §3).